PHP 8.4: fix deprecation notice#2019
Merged
PhilinTv merged 2 commits intopropelorm:masterfrom May 14, 2025
Merged
Conversation
Contributor
gharlan
commented
Dec 8, 2024
20a8279 to
0bc844f
Compare
Contributor
|
I want to merge this into perpl, see perplorm#40. Hope that's ok with you, @gharlan? |
Contributor
Author
|
Yes, of course! |
Contributor
|
This probably should have been merged immediately, it's a really welcome, necessary, uncontroversial fix. |
Merged
Contributor
|
@gharlan would you be able to rebase your work and update the PR please? This will make the mysql tests run (as they have been fixed). Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.