Skip to content

PHP 8.4: fix deprecation notice#2019

Merged
PhilinTv merged 2 commits intopropelorm:masterfrom
gharlan:php84
May 14, 2025
Merged

PHP 8.4: fix deprecation notice#2019
PhilinTv merged 2 commits intopropelorm:masterfrom
gharlan:php84

Conversation

@gharlan
Copy link
Copy Markdown
Contributor

@gharlan gharlan commented Dec 8, 2024

Implicitly marking parameter [...] as nullable is deprecated, the explicit nullable type must be used instead

@mringler
Copy link
Copy Markdown
Contributor

I want to merge this into perpl, see perplorm#40. Hope that's ok with you, @gharlan?

@gharlan
Copy link
Copy Markdown
Contributor Author

gharlan commented Apr 15, 2025

Yes, of course!
(Still hope that it gets also merged into the main Propel repo)

@mringler
Copy link
Copy Markdown
Contributor

This probably should have been merged immediately, it's a really welcome, necessary, uncontroversial fix.
Then again, tests have been broken for over a year now, there are several fixes, like #2007 or #2021, and they don't get merged either.
Adding this was suggested by @oojacoboo, I am waiting for his confirmation and then it'll be part of Perpl.
Thank you for your kind approval, and thank you for the fix!

@smhg
Copy link
Copy Markdown
Contributor

smhg commented Apr 30, 2025

@gharlan would you be able to rebase your work and update the PR please? This will make the mysql tests run (as they have been fixed). Thanks!

@PhilinTv
Copy link
Copy Markdown
Contributor

@gharlan now, when the master is green, we can merge it.
thanks for the PR!

@mringler indeed! now it's merged to the main repo.

@PhilinTv PhilinTv merged commit 275a55e into propelorm:master May 14, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants