Skip to content

Implicitly marking parameter as nullable is deprecated #38

@oojacoboo

Description

@oojacoboo

So, PHP 8.4 deprecated implicit nullability.

    public function withFooQuery(
        callable $callable,
        string $relationAlias = null,  // Can't do this anymore
        ?string $joinType = Criteria::LEFT_JOIN
    )

Instead it must be:

    public function withFooQuery(
        callable $callable,
        ?string $relationAlias = null,
        ?string $joinType = Criteria::LEFT_JOIN
    )

I noticed this error on these methods, but it also occurs in the base classes in setters where the parameter is nullable (fixed by #37), and I'm sure in many others as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions