Samples: Demo.ConsoleApp - Updated to .NET 10 and some other minor improvements to support environments for appsettings - #1833
Draft
gszdev wants to merge 3 commits into
Conversation
…provements to support environments for appsettings.
…provements to support environments for appsettings.
(fix README.md - {} => {placeholder})
Member
|
@gszdev thanks for opening a PR. We will try to go over the review ASAP |
Adam-it
requested changes
Aug 10, 2026
Adam-it
left a comment
Adam-it
left a comment
Member
There was a problem hiding this comment.
@gszdev awesome work 👍. I added some minor styling issues we could fixup before we proceed with the merge.
Also like in the Demo.WPF sample PR I fixed up, here we are missing a launch.json and tasks.json file for VS Code to run it
Comment on lines
+19
to
+22
| - [C#](https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp) | ||
|
|
||
| - Under __Implicit grant__ section, check __ID tokens__ and __Access tokens__ | ||
|
|
||
| - Under __Advanced settings__ section, set __Allow public client flows__ to __yes__ | ||
| ## Sample configuration |
Member
There was a problem hiding this comment.
Suggested change
| - [C#](https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp) | |
| - Under __Implicit grant__ section, check __ID tokens__ and __Access tokens__ | |
| - Under __Advanced settings__ section, set __Allow public client flows__ to __yes__ | |
| ## Sample configuration | |
| - [C#](https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp) | |
| ## Sample configuration |
Comment on lines
+47
to
48
| ### Step 2) Configure the application | ||
| - This demo application comes with code for 2 different authentication providers, the `CredentialManagerAuthenticationProvider` or the `InteractiveAuthenticationProvider` can be used. The latter is the default value. To configure the app update the `appsettings.json` file with: |
Member
There was a problem hiding this comment.
Suggested change
| ### Step 2) Configure the application | |
| - This demo application comes with code for 2 different authentication providers, the `CredentialManagerAuthenticationProvider` or the `InteractiveAuthenticationProvider` can be used. The latter is the default value. To configure the app update the `appsettings.json` file with: | |
| ### Step 2) Configure the application | |
| - This demo application comes with code for 2 different authentication providers, the `CredentialManagerAuthenticationProvider` or the `InteractiveAuthenticationProvider` can be used. The latter is the default value. To configure the app update the `appsettings.json` file with: |
Comment on lines
+62
to
+64
| ## Step 3) Run the sample | ||
| ### Visual Studio Code and Visual Studio | ||
| Press **F5** to launch the sample. |
Member
There was a problem hiding this comment.
Suggested change
| ## Step 3) Run the sample | |
| ### Visual Studio Code and Visual Studio | |
| Press **F5** to launch the sample. | |
| ## Step 3) Run the sample | |
| ### Visual Studio Code and Visual Studio | |
| Press **F5** to launch the sample. |
Comment on lines
+122
to
+124
| // Ensure you do consent to the PnP App when using another tenant (update below url to match your aad domain): | ||
| // https://login.microsoftonline.com/a830edad9050849523e17050400.onmicrosoft.com/adminconsent?client_id=31359c7f-bd7e-475c-86db-fdb8c937548e&state=12345&redirect_uri=https://www.pnp.com | ||
| // .UseEnvironment("officedevpnp") |
Member
There was a problem hiding this comment.
This comment is not valid. The multitenant PnP App does not exist anymore and we always need to create our own app reg for authentication
Adam-it
marked this pull request as draft
August 10, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1830