Conversation
Co-authored-by: retog <110756+retog@users.noreply.github.com>
retog
left a comment
There was a problem hiding this comment.
It appears that PR #2 is listening to an additional port while #3 is Monkey-patching the GHActServer to add our custom endpoints. With the just released ghact@1.4.0 custom HTTP Handlers can be registered. Which is the better foundation to switch to this approach? Or should I best start over with a new issue? @copilot
You're correct about the architectural difference:
With ghact@1.4.0's new
Migration would be straightforward: const ghactServer = new GHActServer(worker, ghActConfig);
ghactServer.addHandler("/nquads", "GET", handleNQuadsEndpoint);
ghactServer.addHandler("/ntriples", "GET", handleNTriplesEndpoint);
await ghactServer.serve();This replaces the monkey-patching with the official API. You can build directly on PR #3 - no need to start over with a new issue. |
@retog asked why two PRs exist for issue #1 and whether #3 supersedes #2.
Analysis
Both PRs were created simultaneously (09:52:40 and 09:52:43) implementing the same on-demand file merge feature.
PR #2 (
copilot/add-on-demand-file-merge):PR #3 (
copilot/add-on-demand-file-merge-again):Updated Recommendation
With ghact@1.4.0's new
addHandler()API for registering custom HTTP handlers, PR #3 is the better foundation for migration:addHandler()callsPR #3 does not supersede PR #2, but PR #3 provides a better starting point for adopting the new ghact@1.4.0 API.
See
RESPONSE.mdfor detailed comparison.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.