Skip to content

Fix: Issue #732 - Viewer plays animation even when set to None #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crimson-and-clover wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Issue #732 - Viewer plays animation even when set to None #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/camera-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class CameraManager {
if (animTracks?.length > 0 && settings.startMode === 'animTrack') {
// use the first animTrack
return animTracks[0];
} else if (isObjectExperience) {
} else if (isObjectExperience && settings.startMode !== 'none') {
// create basic rotation animation if no anim track is specified
initial.calcFocusPoint(tmpv);
return createRotateTrack(initial.position, tmpv, initial.fov);
Expand Down
2 changes: 1 addition & 1 deletion src/schemas/v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ type ExperienceSettings = {
cameras: Camera[],
annotations: Annotation[],

startMode: 'default' | 'animTrack' | 'annotation',
startMode: 'default' | 'animTrack' | 'annotation' | 'none',

hasStartPose?: boolean
};
Expand Down
2 changes: 1 addition & 1 deletion src/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const migrateV2 = (v1: V1): V2 => {
}
}],
annotations: [],
startMode: v1.camera.startAnim === 'animTrack' ? 'animTrack' : 'default',
startMode: v1.camera.startAnim === 'none' ? 'none' : v1.camera.startAnim === 'animTrack' ? 'animTrack' : 'default',
hasStartPose: !!(v1.camera.position && v1.camera.target)
};
};
Expand Down