Fix: Issue #732 - Viewer plays animation even when set to None#128
Open
crimson-and-clover wants to merge 1 commit intoplaycanvas:mainfrom
Open
Fix: Issue #732 - Viewer plays animation even when set to None#128crimson-and-clover wants to merge 1 commit intoplaycanvas:mainfrom
crimson-and-clover wants to merge 1 commit intoplaycanvas:mainfrom
Conversation
add startMode 'none' option
Author
Member
|
Thanks for this PR! We can't take this change right now because it will break existing published scenes that currently auto-animate. We must first deal with the upstream publisher to add a new "do not animate" option before we can make this here change. So let's keep it around, shouldn't be long! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the viewer still started a camera animation even when Animation = None was selected in the Publish panel.
Changes
'none'option tostartModestartMode === 'none'startAnim: 'none'Result
Viewer now correctly respects Animation = None and does not trigger any animation on load.
playcanvas/supersplat#732