Skip to content

docs(upgrade): Adds missing details.#4479

Merged
dlabaj merged 7 commits intopatternfly:mainfrom
edonehoo:iss4459
Mar 11, 2025
Merged

docs(upgrade): Adds missing details.#4479
dlabaj merged 7 commits intopatternfly:mainfrom
edonehoo:iss4459

Conversation

@edonehoo
Copy link
Collaborator

Closes #4459

@edonehoo edonehoo marked this pull request as draft February 19, 2025 19:48
@patternfly-build
Copy link
Collaborator

patternfly-build commented Feb 19, 2025

@edonehoo edonehoo marked this pull request as ready for review February 26, 2025 20:09
@edonehoo
Copy link
Collaborator Author

edonehoo commented Feb 26, 2025

made a variety of changes to try and cover all open requests/issues related to this. if I missed anything please lmk!

@tlabaj:

@adamviktora:

and then cc @nicolethoen in general, per the things you suggested from your upgrade experiences

Copy link
Collaborator

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an excellent iterative improvement! 🥇

Copy link

@adamviktora adamviktora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update overall!

Regarding the css-vars-updater (#4446) I think the section is perfectly fine as the details are explained under the Run tokens-update section above + there is always a link to README.

I am not sure whether some of the Notable changes require that much manual attention (but I may be wrong, cc @nicolethoen) so I left some comments.

Also the Update React tokens section should be updated - left a comment there.

Copy link

@adamviktora adamviktora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 🎉

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just on little update neeeded

@edonehoo edonehoo requested a review from tlabaj March 6, 2025 13:40
@dlabaj dlabaj merged commit a84193d into patternfly:main Mar 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

6 participants

Comments