docs(upgrade): Adds missing details.#4479
Conversation
|
made a variety of changes to try and cover all open requests/issues related to this. if I missed anything please lmk!
and then cc @nicolethoen in general, per the things you suggested from your upgrade experiences |
nicolethoen
left a comment
There was a problem hiding this comment.
I think this is an excellent iterative improvement! 🥇
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Outdated
Show resolved
Hide resolved
adamviktora
left a comment
There was a problem hiding this comment.
Great update overall!
Regarding the css-vars-updater (#4446) I think the section is perfectly fine as the details are explained under the Run tokens-update section above + there is always a link to README.
I am not sure whether some of the Notable changes require that much manual attention (but I may be wrong, cc @nicolethoen) so I left some comments.
Also the Update React tokens section should be updated - left a comment there.
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Outdated
Show resolved
Hide resolved
packages/documentation-site/patternfly-docs/content/get-started/upgrade.md
Show resolved
Hide resolved
tlabaj
left a comment
There was a problem hiding this comment.
Looks good. Just on little update neeeded
Closes #4459