Merged
Conversation
The test wrote two values to a file and relied on a 3-second sleep for the filesystem mtime to advance, which fails when both writes land in the same second (ext4/tmpfs have 1-second mtime granularity). Fix: use os.utime() to explicitly bump mtime after the second write. This is deterministic, instant, and tests the actual cache invalidation logic (mtime comparison) rather than hoping the clock advances. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Implement cross-project memories using "global/" as a reserved topic name that routes to ~/.serena/memories/global/. This replaces the previous scope-parameter approach with a simpler naming convention that leverages the existing topic/directory grouping from #1058. Key changes: - MemoriesManager routes "global/*" names to ~/.serena/memories/global/ - edit_global_memories config option (default: true) protects globals - All memory tools support "global/" prefix transparently - Onboarding check filters global memories (they don't mean project is onboarded) - Dashboard save/delete respect edit_global_memories guard Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract repeated directory-enumeration logic into a _collect helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@butterflysky I don't have write permissions to your fork, so I created a new branch building from yours. FYI |
opcode81
reviewed
Feb 26, 2026
Contributor
Author
|
@opcode81 memory renaming now possible in dashboard I had to add an abstract |
Removed unnecessary intermediate abstract classes
…icate mechanism Apply check for concrete class implementing 'apply' in ToolRegistry Remove obsolete method for enumerating memory tools
opcode81
force-pushed
the
feature/global-memories
branch
from
806fcea to
1c71764
Compare
Fix unhandled error case in list_memories
Contributor
|
I will make some additional improvements before I merge this. |
opcode81
force-pushed
the
feature/global-memories
branch
2 times, most recently
from
4c00caa to
8ec6f0a
Compare
Rename is insufficient when moving across file systems
opcode81
force-pushed
the
feature/global-memories
branch
from
8ec6f0a to
44136cf
Compare
(already reported at project activation)
opcode81
force-pushed
the
feature/global-memories
branch
from
7ca09cd to
d26a4a9
Compare
MischaPanch
commented
Feb 28, 2026
* Improve tool/param descriptions * Remove obsolete tests * Revert mypy config change
opcode81
force-pushed
the
feature/global-memories
branch
from
d2d105f to
57eec27
Compare
Conflicts: src/serena/agent.py src/serena/config/serena_config.py
antigenius0910
added a commit
to antigenius0910/serena
that referenced
this pull request
Mar 3, 2026
Picks up FSharp/dotnet handling fixes from oraios#1115 and global memories feature from oraios#1091. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1006