Report global memories in system prompt instead of at each project activation

Author: opcode81

src/serena/agent.py

@@ -12,6 +12,7 @@
 
 from sensai.util import logging
 from sensai.util.logging import LogTime
+from sensai.util.string import list_string
 
 from interprompt.jinja_template import JinjaTemplate
 from serena import serena_version
@@ -26,7 +27,7 @@
 )
 from serena.dashboard import SerenaDashboardAPI
 from serena.ls_manager import LanguageServerManager
-from serena.project import Project
+from serena.project import MemoriesManager, Project
 from serena.prompt_factory import SerenaPromptFactory
 from serena.task_executor import TaskExecutor
 from serena.tools import ActivateProjectTool, GetCurrentConfigTool, OpenDashboardTool, ReplaceContentTool, Tool, ToolMarker, ToolRegistry
@@ -565,12 +566,15 @@ def _format_prompt(self, prompt_template: str) -> str:
     def create_system_prompt(self) -> str:
         available_tools = self._active_tools
         available_markers = available_tools.tool_marker_names
+        global_memory_names = MemoriesManager.list_global_memories()
+        global_memories_list = list_string(global_memory_names) if global_memory_names else ""
         log.info("Generating system prompt with available_tools=(see active tools), available_markers=%s", available_markers)
         system_prompt = self.prompt_factory.create_system_prompt(
             context_system_prompt=self._format_prompt(self._context.prompt),
             mode_system_prompts=[self._format_prompt(mode.prompt) for mode in self.get_active_modes()],
             available_tools=available_tools.tool_names,
             available_markers=available_markers,
+            global_memories_list=global_memories_list,
         )
 
         # If a project is active at startup, append its activation message

src/serena/generated/generated_prompt_factory.py

@@ -33,6 +33,12 @@ def create_prepare_for_new_conversation(self) -> str:
         return self._render_prompt("prepare_for_new_conversation", locals())
 
     def create_system_prompt(
-        self, *, available_markers: Any, available_tools: Any, context_system_prompt: Any, mode_system_prompts: Any
+        self,
+        *,
+        available_markers: Any,
+        available_tools: Any,
+        context_system_prompt: Any,
+        global_memories_list: Any,
+        mode_system_prompts: Any,
     ) -> str:
         return self._render_prompt("system_prompt", locals())

src/serena/project.py

@@ -304,14 +304,11 @@ def get_activation_message(self) -> str:
         languages_str = ", ".join([lang.value for lang in self.project_config.languages])
         msg += f"\nProgramming languages: {languages_str}; file encoding: {self.project_config.encoding}"
         project_memories = self.memories_manager.list_project_memories()
-        global_memories = self.memories_manager.list_global_memories()
         if project_memories:
             msg += (
                 f"\nAvailable project memories: {json.dumps(project_memories)}\n"
                 + "Use the `read_memory` tool to read these memories later if they are relevant to the task."
             )
-        if global_memories:
-            msg += f"\nAvailable global memories (shared across all projects): {json.dumps(global_memories)}\n"
         if self.project_config.initial_prompt:
             msg += f"\nAdditional project-specific instructions:\n {self.project_config.initial_prompt}"
         return msg

src/serena/resources/config/prompt_templates/system_prompt.yml

@@ -35,10 +35,13 @@ prompts:
     You can understand relationships between symbols by using the `find_referencing_symbols` tool.
     {% endif %}
 
-    {% if 'read_memory' in available_tools %}
+    {% if 'read_memory' in available_tools -%}
     You generally have access to memories and it may be useful for you to read them.
     You infer whether memories are relevant based on their names.
-    {% endif %}
+    {% if global_memories_list -%}
+    The following global (not project-specific) memories are available to you: {{ global_memories_list }}
+    {%- endif -%}
+    {%- endif %}
 
     The context and modes of operation are described below. These determine how to interact with your user
     and which kinds of interactions are expected of you.