Skip to content

Count/report hashes removed by --salts or --cost options#5700

Merged
magnumripper merged 1 commit intoopenwall:bleeding-jumbofrom
magnumripper:remaining-reported-fixes
Mar 18, 2025
Merged

Count/report hashes removed by --salts or --cost options#5700
magnumripper merged 1 commit intoopenwall:bleeding-jumbofrom
magnumripper:remaining-reported-fixes

Conversation

@magnumripper
Copy link
Member

Closes #5699

@magnumripper magnumripper force-pushed the remaining-reported-fixes branch 2 times, most recently from 7e242ca to 49364c2 Compare March 18, 2025 13:30
@magnumripper magnumripper changed the title loader.c: Count/report hashes removed by --salts or --cost options Count/report hashes removed by --salts or --cost options Mar 18, 2025
@magnumripper magnumripper force-pushed the remaining-reported-fixes branch from 49364c2 to 948ef38 Compare March 18, 2025 13:32
@magnumripper
Copy link
Member Author

magnumripper commented Mar 18, 2025

Tested with --cost, --salts, none or both, with or without some hashes cracked.

@magnumripper magnumripper requested a review from solardiz March 18, 2025 13:43
@magnumripper
Copy link
Member Author

magnumripper commented Mar 18, 2025

Example output:

$ ../run/john -v:3 all_tests.in -form:sha512crypt -mask:a -cost=5000 --salts=-2
Loaded 33 password hashes with 15 different salts (2.2x same-salt boost) (sha512crypt, crypt(3) $6$ [SHA512 256/256 AVX2 4x])
Removed 20 password hashes due to --salts
Removed 1 password hash due to --cost
Cracked 2 password hashes (are in ../run/john.pot), use "--show"
Remaining 10 password hashes with 10 different salts
Cost 1 (iteration count) is 5000 for all remaining hashes

I could easily add how many salts each of the filter options removed, but I think it's overkill?

Copy link
Member

@solardiz solardiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only skimmed. I think you also need to update the comment in loader.h on the return value of ldr_fix_database.

Other than that, this is good stuff, but it'd take a long while until I get around to reviewing this for real. So maybe just fix the comment and merge, and we'll rely on your own testing for now.

@magnumripper magnumripper force-pushed the remaining-reported-fixes branch from 948ef38 to ee74654 Compare March 18, 2025 20:31
@magnumripper magnumripper merged commit c9b9c7e into openwall:bleeding-jumbo Mar 18, 2025
34 of 36 checks passed
@magnumripper magnumripper deleted the remaining-reported-fixes branch March 18, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing "Remaining" line when using --cost and/or --salt

2 participants