Count/report hashes removed by --salts or --cost options#5700
Merged
magnumripper merged 1 commit intoopenwall:bleeding-jumbofrom Mar 18, 2025
Merged
Conversation
7e242ca to
49364c2
Compare
49364c2 to
948ef38
Compare
Member
Author
|
Tested with |
Member
Author
|
Example output: I could easily add how many salts each of the filter options removed, but I think it's overkill? |
solardiz
requested changes
Mar 18, 2025
Member
solardiz
left a comment
There was a problem hiding this comment.
I only skimmed. I think you also need to update the comment in loader.h on the return value of ldr_fix_database.
Other than that, this is good stuff, but it'd take a long while until I get around to reviewing this for real. So maybe just fix the comment and merge, and we'll rely on your own testing for now.
948ef38 to
ee74654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5699