Missing "Remaining" line when using --cost and/or --salt #5699
Description
The "Remaining..." message is sometimes entirely missing when excluding hashes with --cost. I believe some of the problems has been forever but the "Remaining" used to be correct. The behavior changed slightly with 6d7b3f5, for better and worse.
The following examples use all 7z samples.
Current Bleeding, none cracked and 1 filtered with --cost:
Loaded 8 password hashes with 8 different salts (7z, 7-Zip archive encryption [SHA256 256/256 AVX2 8x AES])
Loaded hashes with cost 1 (iteration count) varying from 262144 to 524288
Loaded hashes with cost 2 (padding size) varying from 4 to 14
The "Remaining" line is missing entirely, so this doesn't report the fact that --cost removed one hash at all (you will see it if calling detailed status). We should ideally add a line saying something like "Removed 1 hash due to cost constraint(s)" and (more important to me) a "Remaining" line should be emitted.
Current Bleeding, 3 already cracked and 1 filtered with --cost:
Loaded 8 password hashes with 8 different salts (7z, 7-Zip archive encryption [SHA256 256/256 AVX2 8x AES])
Cracked 3 password hashes (are in ../run/john.pot), use "--show"
Remaining 4 password hashes with 4 different salts
Remaining hashes with cost 1 (iteration count) varying from 262144 to 524288
Remaining hashes with cost 2 (padding size) varying from 11 to 14
The "Cracked" and "Remaining" lines are correct here, it just doesn't explain to the user what happened to the eighth hash except the "Loaded hashes with cost" lines very subtly changed to "Remaining hashes with cost" (I only noticed now) but that also happens with some cracked and none filtered.
Before 6d7b3f5, none cracked and 1 filtered with --cost:
Loaded 8 password hashes with 8 different salts (7z, 7-Zip archive encryption [SHA256 256/256 AVX2 8x AES])
Cracked 1 password hash (is in ../run/john.pot), use "--show"
Remaining 7 password hashes with 7 different salts
Remaining hashes with cost 1 (iteration count) varying from 262144 to 524288
Remaining hashes with cost 2 (padding size) varying from 4 to 14
This older version had a correct "Remaining" line for this case, although it listed the filtered hash as cracked instead of filtered.
Before 6d7b3f5, 3 already cracked and 1 filtered with --cost:
Loaded 8 password hashes with 8 different salts (7z, 7-Zip archive encryption [SHA256 256/256 AVX2 8x AES])
Cracked 4 password hashes (are in ../run/john.pot), use "--show"
Remaining 4 password hashes with 4 different salts
Remaining hashes with cost 1 (iteration count) varying from 262144 to 524288
Remaining hashes with cost 2 (padding size) varying from 11 to 14
Basically the same problem here.