Verify blob version for cached model#32940
Merged
olpipi merged 11 commits intoopenvinotoolkit:masterfrom Jan 20, 2026
Merged
Conversation
ba6aca4 to
788b198
Compare
788b198 to
65f945a
Compare
praasz
reviewed
Dec 1, 2025
65f945a to
d3e6dab
Compare
a8c0431 to
4e94903
Compare
t-jankowski
reviewed
Dec 4, 2025
t-jankowski
reviewed
Dec 4, 2025
fabf116 to
b621a82
Compare
t-jankowski
approved these changes
Dec 10, 2025
praasz
reviewed
Dec 11, 2025
Comment on lines
+84
to
+89
| bool is_version_compatible(const Version& comparing_version, | ||
| const Version& base_version, | ||
| const VersionCompatibilityPolicy& policy = {}) { | ||
| if (comparing_version > base_version) { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| bool is_version_compatible(const Version& comparing_version, | |
| const Version& base_version, | |
| const VersionCompatibilityPolicy& policy = {}) { | |
| if (comparing_version > base_version) { | |
| return false; | |
| } | |
| Make it explicit and if policy is not required we can add simpler version without 3rd parameter and call as first step in this function. | |
| bool is_version_compatible(const Version& comparing_version, | |
| const Version& base_version, | |
| const VersionCompatibilityPolicy& policy) { |
| size_t max_build_diff = std::numeric_limits<size_t>::max(); | ||
| }; | ||
|
|
||
| inline bool is_version_compatible(const Version& older_version, |
Contributor
There was a problem hiding this comment.
Can some doxy for this utils be added?
To have quick hint which version is compatible with and how policy is used.
Is there a test where e.g OV version 27.0 introduce compatibility brake, all caches before 2027 are not compatible. Is possible to apply such change in code?
b88cd56 to
ed94537
Compare
ed94537 to
3c41d17
Compare
praasz
reviewed
Jan 13, 2026
praasz
reviewed
Jan 13, 2026
This reverts commit b621a82.
4fde7a7 to
c604a4f
Compare
praasz
approved these changes
Jan 20, 2026
Naseer-010
pushed a commit
to Naseer-010/openvino
that referenced
this pull request
Feb 18, 2026
### Details: - Add c++ struct to store openvino build version. Add a build number parser. - Parse compiled blob version and compare it with runtime version - Add tests ### Tickets: - CVS-176170 - CVS-176185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: