Fix incorrect camera matrices in scene normalization#285
Merged
matthewdcong merged 1 commit intoopenvdb:mainfrom Apr 18, 2026
Merged
Fix incorrect camera matrices in scene normalization#285matthewdcong merged 1 commit intoopenvdb:mainfrom
matthewdcong merged 1 commit intoopenvdb:mainfrom
Conversation
matthewdcong
requested review from
harrism and
swahtz
and removed request for
a team
Signed-off-by: Matthew Cong <mcong@nvidia.com>
matthewdcong
force-pushed
the
fix_scene_normalization
branch
from
45f19da to
6dce33d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scene normalization code incorrectly stores a local reference to
camera_to_world_matricesinstead ofworld_to_camera_matriceswhich leads to an incorrect inverted transform being passed to the similarity normalization leading to an incorrect scene scale.