8373793: TestDynamicStore.java '/manual' disables use of '/timeout'

[rm-gh-8]

Backporting JDK-8373793: TestDynamicStore.java '/manual' disables use of '/timeout'.

This PR removes the /timeout tag from TestDynamicStore.java because it conflicts with the /manual tag and causes errors.

For parity with Oracle JDK.

Ran related tests on macos-aarch64:

~/github/jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/sun/security/krb5/config/native/TestDynamicStore.java

Screenshot:

Result:

As expected, it provides a warning dialog and fails when user lacks permissions.

TestDynamicStore-Failure.jtr.txt

sudo -E ~/github/jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/sun/security/krb5/config/native/TestDynamicStore.java

Result:

Success

TestDynamicStore-Success.jtr.txt

---

Progress

• JDK-8373793 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373793: TestDynamicStore.java '/manual' disables use of '/timeout' (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/297/head:pull/297
$ git checkout pull/297

Update a local copy of the PR:
$ git checkout pull/297
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/297/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 297

View PR using the GUI difftool:
$ git pr show -t 297

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/297.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into pr/292 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373793: TestDynamicStore.java '/manual' disables use of '/timeout'

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 04: Full - Incremental (4e7cc563)
• 03: Full - Incremental (53366ae3)
• 02: Full - Incremental (baf0264e)
• 01: Full - Incremental (62c44de9)
• 00: Full (62c44de9)

[rm-gh-8]

/approval request for backport of JDK-8373793: TestDynamicStore.java '/manual' disables use of '/timeout'.

This is a test fix.

For parity with Oracle JDK.

[openjdk]

@rm-gh-8
8373793: The approval request has been created successfully.

[GoeLin]

Thanks for the helpful explanations.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8373793-V25
git fetch https://git.openjdk.org/jdk25u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@rm-gh-8 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

⚠️ @rm-gh-8 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8373793-V25
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[rm-gh-8]

My apologies. I needed to force push to fix an issue that resulted from the merge with master.

[rm-gh-8]

Re-ran related tests on macos-aarch64:

~/github/jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/sun/security/krb5/config/native/TestDynamicStore.java

Screenshot:

Result:

As expected, it provides a warning dialog and fails when user lacks permissions.

Failure-TestDynamicStore.jtr.txt

sudo -E ~/github/jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/sun/security/krb5/config/native/TestDynamicStore.java

Result:

Success

Success-TestDynamicStore.jtr.txt