Skip to content

8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo#292

Closed
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8361894-V25
Closed

8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo#292
rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
rm-gh-8:JDK-8361894-V25

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Feb 19, 2026

Backporting JDK-8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo.

This PR adds a UI popup that detects and warns users when TestDynamicStore.java is run without required sudo privileges, preventing confusing access-related failures.

For parity with Oracle JDK.

Ran related tests on macos-aarch64:

sudo -E ~/github/jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/sun/security/krb5/config/native/TestDynamicStore.java

Test Result: Error. Parse Exception: '/manual' disables use of '/timeout'

The test fails due to https://bugs.openjdk.org/browse/JDK-8373793, which will be backported in a dependent PR (#297), where the test successfully executes with the behavior indicated in this PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8361894 needs maintainer approval

Issue

  • JDK-8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/292/head:pull/292
$ git checkout pull/292

Update a local copy of the PR:
$ git checkout pull/292
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/292/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 292

View PR using the GUI difftool:
$ git pr show -t 292

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/292.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 19, 2026

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 19, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport f73e56e24f0edfaeb99e2106a56725ea033bd6d6 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo Feb 19, 2026
@openjdk
Copy link

openjdk bot commented Feb 19, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 19, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review February 19, 2026 22:40
@openjdk
Copy link

openjdk bot commented Feb 19, 2026

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 19, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 19, 2026

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Feb 20, 2026

/approval request for backport of JDK-8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo.

This is a test fix.

For parity with Oracle JDK.

The test fails due to https://bugs.openjdk.org/browse/JDK-8373793, which will be backported in a dependent PR (#297), where the test successfully executes with the behavior indicated in this PR.

@openjdk
Copy link

openjdk bot commented Feb 20, 2026

@rm-gh-8
8361894: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 20, 2026
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Feb 23, 2026

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 23, 2026
@openjdk
Copy link

openjdk bot commented Feb 23, 2026

@rm-gh-8
Your change (at version 30ba173) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 23, 2026

Going to push as commit 1371f0a.
Since your change was applied there have been 5 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 23, 2026
@openjdk openjdk bot closed this Feb 23, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 23, 2026
@openjdk
Copy link

openjdk bot commented Feb 23, 2026

@phohensee @rm-gh-8 Pushed as commit 1371f0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants