8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo#292
8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo#292rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo. This is a test fix. For parity with Oracle JDK. The test fails due to https://bugs.openjdk.org/browse/JDK-8373793, which will be backported in a dependent PR (#297), where the test successfully executes with the behavior indicated in this PR. |
|
/integrate |
|
/sponsor |
|
Going to push as commit 1371f0a.
Your commit was automatically rebased without conflicts. |
|
@phohensee @rm-gh-8 Pushed as commit 1371f0a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting JDK-8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo.
This PR adds a UI popup that detects and warns users when TestDynamicStore.java is run without required sudo privileges, preventing confusing access-related failures.
For parity with Oracle JDK.
Ran related tests on macos-aarch64:
sudo -E ~/github/jtreg/build/images/jtreg/bin/jtreg -nativepath:./build/macosx-aarch64-server-release/images/test/jdk/jtreg/native -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/sun/security/krb5/config/native/TestDynamicStore.java
Test Result: Error. Parse Exception: '/manual' disables use of '/timeout'The test fails due to https://bugs.openjdk.org/browse/JDK-8373793, which will be backported in a dependent PR (#297), where the test successfully executes with the behavior indicated in this PR.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/292/head:pull/292$ git checkout pull/292Update a local copy of the PR:
$ git checkout pull/292$ git pull https://git.openjdk.org/jdk25u-dev.git pull/292/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 292View PR using the GUI difftool:
$ git pr show -t 292Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/292.diff
Using Webrev
Link to Webrev Comment