[Subtyping Generator] Generate subtype check for runtime static-types#4327
Merged
SupunS merged 9 commits intofeature/subtype-genfrom Nov 14, 2025
Merged
[Subtyping Generator] Generate subtype check for runtime static-types#4327SupunS merged 9 commits intofeature/subtype-genfrom
SupunS merged 9 commits intofeature/subtype-genfrom
Conversation
Benchstat comparison
Results
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SupunS
commented
Nov 10, 2025
619bfa6 to
2eef683
Compare
6 tasks
… into supun/subtype-gen-statictypes
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
turbolent
approved these changes
Nov 13, 2025
Member
turbolent
left a comment
There was a problem hiding this comment.
Great work! 👏
Just to clarify the currently generated code falls back to converting to sema types when necessary (e.g. to determine if a type is resource-typed, which isn't known at the static type level), right?
Member
Author
@turbolent Yes, that's correct. |
This was referenced Nov 13, 2025
Co-authored-by: Bastian Müller <bastian@turbolent.com>
8c8dbfe to
ee38b06
Compare
RZhang05
approved these changes
Nov 13, 2025
… into supun/subtype-gen-statictypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #3691
Description
Includes only the changes to related to the subtype-check "generation". This doesn't integrate the generated function to the runtime. I have opened a separate PR #4322 to integrate the generated function.
masterbranchFiles changedin the Github PR explorer