[Subtyping Generator] Test and improve generated runtime subtype check by SupunS · Pull Request #4335 · onflow/cadence

SupunS · 2025-11-13T20:03:49Z

Work towards #3691

Depends on #4327

Description

Run the same set of tests added in #4332 for the generated static-type checking function as well. Fixed the gaps uncovered during tests.

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

runtime/subtype_check_test.go

… into supun/subtype-gen-statictypes-tests

encoding/ccf/simpletype_test.go

github-actions · 2025-11-14T17:27:17Z

Benchstat comparison

Base branch: onflow:feature/subtype-gen
Base commit: 3b54e67

Results

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	406µs ± 0%	419µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/encoding/ccf goos:linux goarch:amd64
DecodeBatchEventsCCF-4	131ms ± 0%	134ms ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	416ms ± 0%	428ms ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	2.90µs ± 0%	2.95µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-4	2.17µs ± 0%	2.22µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	2.88µs ± 0%	2.90µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	3.32µs ± 0%	3.30µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	2.16µs ± 0%	2.22µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	2.54µs ± 0%	2.63µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-4	2.64µs ± 0%	2.71µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	2.57µs ± 0%	2.64µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-4	2.17µs ± 0%	2.24µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-4	2.62µs ± 0%	2.67µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-4	10.2µs ± 0%	10.4µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-4	5.88µs ± 0%	5.97µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	9.28µs ± 0%	9.50µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	12.6µs ± 0%	13.0µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	6.04µs ± 0%	6.17µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	7.81µs ± 0%	8.00µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-4	8.26µs ± 0%	8.42µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	7.46µs ± 0%	7.62µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-4	5.99µs ± 0%	6.04µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-4	8.26µs ± 0%	8.40µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-4	4.13ms ± 0%	4.07ms ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/encoding/ccf goos:linux goarch:amd64
EncodeBatchEventsCCF-4	88.7ms ± 0%	89.5ms ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	97.0ms ± 0%	96.9ms ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.95µs ± 0%	1.99µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.58µs ± 0%	1.57µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.94µs ± 0%	1.93µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.21µs ± 0%	2.22µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.62µs ± 0%	1.62µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.76µs ± 0%	1.78µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-4	1.77µs ± 0%	1.79µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.75µs ± 0%	1.77µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-4	1.58µs ± 0%	1.58µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.79µs ± 0%	1.79µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4	2.28µs ± 0%	2.24µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4	1.33µs ± 0%	1.33µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	2.05µs ± 0%	2.06µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.79µs ± 0%	2.80µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	1.36µs ± 0%	1.34µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	1.73µs ± 0%	1.73µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4	2.00µs ± 0%	1.98µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	1.59µs ± 0%	1.57µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4	1.33µs ± 0%	1.34µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4	1.97µs ± 0%	1.97µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	260ns ± 0%	260ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	78.3ns ± 0%	78.1ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	21.2µs ± 0%	20.8µs ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	2.32ms ± 0%	2.19ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	1.04µs ± 0%	1.02µs ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	319ns ± 0%	334ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	2.18ns ± 0%	2.16ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	81.5ns ± 0%	90.5ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	600µs ± 0%	623µs ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	669µs ± 0%	641µs ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	2.69ms ± 0%	2.68ms ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	12.0ms ± 0%	12.2ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	15.0µs ± 0%	14.9µs ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	27.7µs ± 0%	27.0µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	230ns ± 0%	224ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	90.3ns ± 0%	93.2ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	303ns ± 0%	319ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	69.9ns ± 0%	71.0ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	152kB ± 0%	153kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/encoding/ccf goos:linux goarch:amd64
DecodeBatchEventsCCF-4	71.5MB ± 0%	71.5MB ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	262MB ± 0%	262MB ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	1.50kB ± 0%	1.50kB ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	1.31kB ± 0%	1.31kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.58kB ± 0%	1.58kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.60kB ± 0%	1.60kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.36kB ± 0%	1.36kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	1.48kB ± 0%	1.48kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	1.42kB ± 0%	1.42kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.41kB ± 0%	1.41kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	1.31kB ± 0%	1.31kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	1.43kB ± 0%	1.43kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	6.37kB ± 0%	6.37kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	3.84kB ± 0%	3.84kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	5.82kB ± 0%	5.82kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	7.80kB ± 0%	7.80kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	3.90kB ± 0%	3.90kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	4.86kB ± 0%	4.86kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	5.23kB ± 0%	5.23kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	4.78kB ± 0%	4.78kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	3.86kB ± 0%	3.86kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	5.23kB ± 0%	5.23kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-4	1.48MB ± 0%	1.48MB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/encoding/ccf goos:linux goarch:amd64
EncodeBatchEventsCCF-4	65.8MB ± 0%	65.8MB ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	40.7MB ± 0%	40.7MB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.29kB ± 0%	1.29kB ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.24kB ± 0%	1.24kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.51kB ± 0%	1.51kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.48kB ± 0%	1.48kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.42kB ± 0%	1.42kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.50kB ± 0%	1.50kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	1.29kB ± 0%	1.29kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.27kB ± 0%	1.27kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	1.24kB ± 0%	1.24kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.29kB ± 0%	1.29kB ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	896B ± 0%	896B ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	536B ± 0%	536B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	920B ± 0%	920B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.11kB ± 0%	1.11kB ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	584B ± 0%	584B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	784B ± 0%	784B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	808B ± 0%	808B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	672B ± 0%	672B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	544B ± 0%	544B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	800B ± 0%	800B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	8.30kB ± 0%	8.30kB ± 0%	~	(all equal)
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	976B ± 0%	976B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	232B ± 0%	232B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	159kB ± 0%	159kB ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	174kB ± 0%	173kB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	1.77MB ± 0%	1.76MB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	9.28MB ± 0%	9.27MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	8.04kB ± 0%	8.04kB ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	9.80kB ± 0%	9.80kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	96.0B ± 0%	96.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	48.0B ± 0%	48.0B ± 0%	~	(all equal)

	allocs/op		delta
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	2.46k ± 0%	2.46k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/encoding/ccf goos:linux goarch:amd64
DecodeBatchEventsCCF-4	1.53M ± 0%	1.53M ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	5.44M ± 0%	5.44M ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	27.0 ± 0%	27.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	33.0 ± 0%	33.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	27.0 ± 0%	27.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	32.0 ± 0%	32.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	27.0 ± 0%	27.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	32.0 ± 0%	32.0 ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	142 ± 0%	142 ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	79.0 ± 0%	79.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	118 ± 0%	118 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	179 ± 0%	179 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	78.0 ± 0%	78.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	99.0 ± 0%	99.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	110 ± 0%	110 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	98.0 ± 0%	98.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	79.0 ± 0%	79.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	110 ± 0%	110 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
Emit-4	39.0k ± 0%	39.0k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/encoding/ccf goos:linux goarch:amd64
EncodeBatchEventsCCF-4	1.00M ± 0%	1.00M ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	902k ± 0%	902k ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	21.0 ± 0%	21.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	17.0 ± 0%	17.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	16.0 ± 0%	16.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	14.0 ± 0%	14.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	176 ± 0%	176 ± 0%	~	(all equal)
InterpretRecursionFib-4	17.7k ± 0%	17.7k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	2.98k ± 0%	2.98k ± 0%	~	(all equal)
RuntimeFungibleTokenTransferVM-4	3.00k ± 0%	3.00k ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-4	36.7k ± 0%	36.7k ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	159k ± 0%	159k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	113 ± 0%	113 ± 0%	~	(all equal)
RuntimeVMInvokeContractImperativeFib-4	197 ± 0%	197 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

sema/subtype_check.gen.go

turbolent

Nice!

encoding/ccf/simpletype_test.go

SupunS added 3 commits November 13, 2025 10:16

Run the subtype checking tests also with static-types

4de93be

Add storable type support

61f779b

Fix rules

ac0618b

SupunS self-assigned this Nov 13, 2025

SupunS added Bugfix Testing labels Nov 13, 2025

SupunS commented Nov 13, 2025

View reviewed changes

runtime/subtype_check_test.go Show resolved Hide resolved

runtime/subtype_check_test.go Show resolved Hide resolved

runtime/subtype_check_test.go Show resolved Hide resolved

Fix tests

407ea2e

SupunS changed the title ~~[Subtyping Generator] Test and improve generated subtype check for runtime static-types~~ [Subtyping Generator] Test and improve generated runtime subtype check Nov 13, 2025

SupunS mentioned this pull request Nov 13, 2025

[Subtyping Generator] Switch to static-types for runtime subtype checking #4322

Open

6 tasks

Fix subtype check generator test

4f487b5

Base automatically changed from supun/subtype-gen-statictypes to feature/subtype-gen November 14, 2025 17:07

Merge branch 'feature/subtype-gen' of https://github.com/onflow/cadence…

8b2b055

… into supun/subtype-gen-statictypes-tests

SupunS force-pushed the supun/subtype-gen-statictypes-tests branch from 17d54b3 to 8b2b055 Compare November 14, 2025 17:07

Fix lint

4fe1ea6

SupunS marked this pull request as ready for review November 14, 2025 17:17

SupunS requested review from RZhang05 and turbolent as code owners November 14, 2025 17:17

SupunS commented Nov 14, 2025

View reviewed changes

encoding/ccf/simpletype_test.go Outdated Show resolved Hide resolved

RZhang05 approved these changes Nov 14, 2025

View reviewed changes

sema/subtype_check.gen.go Show resolved Hide resolved

turbolent approved these changes Nov 14, 2025

View reviewed changes

encoding/ccf/simpletype_test.go Outdated Show resolved Hide resolved

Add exporting support for storable static type

0c93365

SupunS merged commit 19aeaaa into feature/subtype-gen Nov 14, 2025
10 of 12 checks passed

SupunS deleted the supun/subtype-gen-statictypes-tests branch November 14, 2025 20:43

BrewTestBot mentioned this pull request Nov 20, 2025

cadence 1.8.4 Homebrew/homebrew-core#255165

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Subtyping Generator] Test and improve generated runtime subtype check #4335

[Subtyping Generator] Test and improve generated runtime subtype check #4335
SupunS merged 8 commits intofeature/subtype-genfrom
supun/subtype-gen-statictypes-tests

SupunS commented Nov 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

turbolent left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

SupunS commented Nov 13, 2025

Description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchstat comparison

Uh oh!

Uh oh!

turbolent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Nov 14, 2025 •

edited

Loading