Support fitting titer models per reference virus#261
Draft
Conversation
Allow titer collections to request a titer model run per reference virus in each collection. The workflow aggregates the resulting model results into a single measurements panel JSON which allows users to display inferred titer measurements per virus in the tree in both the measurements panel and in the tree coloring by measurements for a reference selected from the panel. This logic attempts to recreate a nextflu feature which allows users to click on a titer reference virus to color the tree by the measurements against that virus and then choose to color by the titer model fit to that virus. Related to #214
huddlej
force-pushed
the
run-titer-models-per-reference
branch
from
393c7c4 to
1843dcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Allow titer collections to request a titer model run per reference virus in each collection. The workflow aggregates the resulting model results into a single measurements panel JSON which allows users to display inferred titer measurements per virus in the tree in both the measurements panel and in the tree coloring by measurements for a reference selected from the panel. This logic attempts to recreate a nextflu feature which allows users to click on a titer reference virus to color the tree by the measurements against that virus and then choose to color by the titer model fit to that virus.
This is a first attempt at recreating the original nextflu feature, but this is not actually the same approach that nextflu uses. The nextflu logic uses a single titer substitution model that has been fit to all available measurements, finds the substitutions that exist between the selected reference node and each other node in the tree, and sums the titer model effects of those substitutions. That implementation allows the inferred measurements to take advantage of all titer data, while the current PR's approach fits a different model per reference using only the data where that virus is the serum strain. I plan to update this PR later with something closer to the nextflu approach.
See Slack for additional context.
Related issue(s)
Related to #214
Checklist