Skip to content

feat(signaling): Don't send all room userids in signaling server requests#16759

Open
fancycode wants to merge 2 commits intomainfrom
remove-alluserids
Open

feat(signaling): Don't send all room userids in signaling server requests#16759
fancycode wants to merge 2 commits intomainfrom
remove-alluserids

Conversation

@fancycode
Copy link
Member

☑️ Resolves

🛠️ API Checklist

🚧 Tasks

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

…ests

Signed-off-by: Joachim Bauch <bauch@struktur.de>
@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: signaling 📶 Internal and external signaling backends performance 🚀 labels Jan 19, 2026
@nickvergessen nickvergessen added this to the 🍏 Next RC (33) milestone Jan 19, 2026
@nickvergessen nickvergessen requested review from danxuliu and nickvergessen and removed request for nickvergessen January 19, 2026 16:29
@nickvergessen
Copy link
Member

Requires strukturag/nextcloud-spreed-signaling#1175

What's the exact merge order? I assume:

  • Make sure all mobile apps and web don't use it
  • Drop in HPB
  • Drop in Talk

@fancycode
Copy link
Member Author

What's the exact merge order? I assume:

  • Make sure all mobile apps and web don't use it

Yes, that must be checked first.

  • Drop in HPB
  • Drop in Talk

Here the order doesn't really matter. If the whole user lists are no longer sent by Talk, the HPB will not forward them / skip some notifications (see strukturag/nextcloud-spreed-signaling#1175 (comment)).

If the HPB doesn't parse them, it will only send the changed ones / skip some notifications.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: signaling 📶 Internal and external signaling backends performance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove alluserids and similar lists from the signaling messages

2 participants