Convert pretty much all built ins to use ClassDescriptors#2332
Draft
aardvark179 wants to merge 40 commits intomozilla:masterfrom
Draft
Convert pretty much all built ins to use ClassDescriptors#2332aardvark179 wants to merge 40 commits intomozilla:masterfrom
ClassDescriptors#2332aardvark179 wants to merge 40 commits intomozilla:masterfrom
Conversation
Contributor
Author
|
I've added the conversion of iterators, generators, and generator functions, to this PR. That also required some bug fixes around our iteration handling, and I've made the choice that we should do the spec compliant thing if the language version is greater than 1.8, and preserve the old spider monkey behaviour with older JS language versions. |
aardvark179
force-pushed
the
aardvark179-descriptors-2
branch
7 times, most recently
from
ebd7632 to
bc1782d
Compare
aardvark179
force-pushed
the
aardvark179-descriptors-2
branch
5 times, most recently
from
85d21f7 to
406b7d0
Compare
aardvark179
force-pushed
the
aardvark179-descriptors-2
branch
from
406b7d0 to
bf5829f
Compare
aardvark179
force-pushed
the
aardvark179-descriptors-2
branch
from
bf5829f to
a8b1147
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stacks on top of #2331 and converts almost all built ins from
LambdaConstructortoClassDescriptor. I think the only ones left areNativeSymbol,JavaAdapter, and some test cases. I'll add those before moving this from draft.