Make this an Object not a Scriptable, and handle toObject for non-strict functions.#2334
Draft
aardvark179 wants to merge 42 commits intomozilla:masterfrom
Draft
Make this an Object not a Scriptable, and handle toObject for non-strict functions.#2334aardvark179 wants to merge 42 commits intomozilla:masterfrom
this an Object not a Scriptable, and handle toObject for non-strict functions.#2334aardvark179 wants to merge 42 commits intomozilla:masterfrom
Conversation
aardvark179
force-pushed
the
aardvark179-this-as-object
branch
3 times, most recently
from
042d6b3 to
443a5c8
Compare
aardvark179
force-pushed
the
aardvark179-this-as-object
branch
6 times, most recently
from
cbd84ca to
219b830
Compare
aardvark179
force-pushed
the
aardvark179-this-as-object
branch
6 times, most recently
from
0923587 to
74f39e4
Compare
aardvark179
force-pushed
the
aardvark179-this-as-object
branch
2 times, most recently
from
23cd9f7 to
38b044a
Compare
aardvark179
force-pushed
the
aardvark179-this-as-object
branch
from
38b044a to
0fcbe1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stacks on top of #2332, adding two commits
Convert thisObj to be Object not Scriptable.
Update test 262 properties.
This PR converts
thisto be anObjectrather than aScriptable. We then handle thetoObjectconversion in functions.