Change APIs and use sites to use the new VarScope type.#2330
Draft
aardvark179 wants to merge 9 commits intomozilla:masterfrom
Draft
Change APIs and use sites to use the new VarScope type.#2330aardvark179 wants to merge 9 commits intomozilla:masterfrom
VarScope type.#2330aardvark179 wants to merge 9 commits intomozilla:masterfrom
Conversation
aardvark179
force-pushed
the
aardvark179-varscope-in-call-and-construct
branch
2 times, most recently
from
be9a9b8 to
e3c28c3
Compare
aardvark179
force-pushed
the
aardvark179-varscope-in-call-and-construct
branch
6 times, most recently
from
07150ed to
cdd284d
Compare
aardvark179
force-pushed
the
aardvark179-varscope-in-call-and-construct
branch
from
cdd284d to
a44ee7d
Compare
aardvark179
force-pushed
the
aardvark179-varscope-in-call-and-construct
branch
5 times, most recently
from
0eaaf0f to
6268fdd
Compare
aardvark179
force-pushed
the
aardvark179-varscope-in-call-and-construct
branch
from
6268fdd to
8a76c34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stacks on top of #2329 and is the next stage in resolving #2163.
This PR changes the
callandconstructsignatures to make the scopesVarScopes, then changes theJSCodeAPIs, and then adds a series of commits that change all the places these are implemented to make them obey the new type. We can do this gradually becauseVarScopeis a subtype ofScriptableand so method references can be adapted.This change also has to include @ZZZank's change #2298 to ensure that serialisation of native methods can still be done, without it there are too many ordering issues with deserialisation and the continuations tests will fail.
Like the previous PR in this series each commit involved in this change can be taken separately, and the PR can be split for purposes of review if desired.