Skip to content

Convert call and construct APIs to take VarScope scopes#2361

Open
aardvark179 wants to merge 2 commits intomozilla:masterfrom
aardvark179:aardvark179-core-apis-to-varscope
Open

Convert call and construct APIs to take VarScope scopes#2361
aardvark179 wants to merge 2 commits intomozilla:masterfrom
aardvark179:aardvark179-core-apis-to-varscope

Conversation

@aardvark179
Copy link
Copy Markdown
Contributor

This is the first two commits of #2330, and will be followed by PRs that convert the use sites to the new type. We can stage this because the when converting method references to functional interfaces the Java compiler allows for widening of types, in this case VarScope to Scriptable.

@aardvark179 aardvark179 force-pushed the aardvark179-core-apis-to-varscope branch 2 times, most recently from af9858f to 195b96a Compare April 3, 2026 21:16
@aardvark179 aardvark179 force-pushed the aardvark179-core-apis-to-varscope branch from 195b96a to b5d3d3b Compare April 3, 2026 23:02
@aardvark179
Copy link
Copy Markdown
Contributor Author

I think the recursive ConsString problem is likely an intermittent failure, and I'm not really sure what this test is trying to exercise. If we're interested in the total number of appends then we should simply increase the ConsString append limit, or change the strategy of what is being appended. At the moment the four thousand recursive iterations are only really testing that the stack per call is always below a limit along with the test harness parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant