feat: add support for setting airplane mode with environment variables - #3192
Open
sailsdima wants to merge 6 commits into
Open
feat: add support for setting airplane mode with environment variables#3192sailsdima wants to merge 6 commits into
sailsdima wants to merge 6 commits into
Conversation
Fishbowler
reviewed
Apr 18, 2026
sailsdima
marked this pull request as ready for review
April 18, 2026 21:43
Fishbowler
force-pushed
the
setAirplaneMode-env-variables-support
branch
2 times, most recently
from
June 15, 2026 20:17
80306a3 to
c29354e
Compare
Fishbowler
force-pushed
the
setAirplaneMode-env-variables-support
branch
4 times, most recently
from
July 1, 2026 10:50
63f6920 to
3a11c58
Compare
…s + Unit and e2e test coverage
If someone passed a boolean, for example
Fishbowler
force-pushed
the
setAirplaneMode-env-variables-support
branch
from
July 2, 2026 09:04
3a11c58 to
b927a8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds environment variable support to the
setAirplaneModecommand. Previously,setAirplaneModeonly accepted hardcoded literal values (enabled/disabled). With this change, users can now pass environment variables as well.copilot:summary
What Changed:
SetAirplaneModeCommand- now accepts String value instead of AirplaneValue enum (to support ${...}) variable references. Variables are resolved at runtime via evaluateScripts().YamlSetAirplaneMode- rewrote deserializer to pass through variable references at parse time; literal values are still validated eagerly.Orchestra- UsesresolvedValue()instead of direct enum access.Usage Example:
Testing
Unit tests:
YamlCommandReaderTest(parsing with env vars + invalid value error),CommandDescriptionTest(description evaluation).Integration test: added new test in
IntegrationTestthat runs runs setAirplaneMode with env variables through the full pipeline.e2e test: Extended existing e2e
setAirplaneMode.yamlto test env variable for airplane mode.All existing tests pass with no regressions.
Issues fixed
#2878