Tighten parsing of optional flag

Author: Fishbowler

maestro-orchestra/src/main/java/maestro/orchestra/yaml/YamlSetAirplaneMode.kt

@@ -43,7 +43,7 @@ class YamlSetAirplaneModeDeserializer : JsonDeserializer<YamlSetAirplaneMode>()
         val value = valueNode.asText()
         validateIfLiteral(value)
         val label = (root.get("label") as? TextNode)?.textValue()
-        val optional = root.get("optional")?.toString()?.toBoolean() ?: false
+        val optional = root.get("optional")?.asBoolean() ?: false
 
         return YamlSetAirplaneMode(
             value = value,

maestro-orchestra/src/test/java/maestro/orchestra/yaml/YamlCommandReaderTest.kt

@@ -909,6 +909,22 @@ internal class YamlCommandReaderTest {
         assertThat(messages).contains("It seems you provided invalid input: true")
     }
 
+    @Test
+    fun `setAirplaneMode object form parses label and optional`(
+        @YamlFile("034_setAirplaneMode_optional.yaml") commands: List<Command>
+    ) {
+        assertThat(commands).containsExactly(
+            ApplyConfigurationCommand(MaestroConfig(
+                appId = "com.example.app",
+            )),
+            SetAirplaneModeCommand(
+                value = "enabled",
+                label = "Maybe enable airplane mode",
+                optional = true,
+            ),
+        )
+    }
+
     @Test
     fun `findUnknownWorkspaceConfigKeys returns empty for valid keys`() {
         val config = """

maestro-orchestra/src/test/resources/YamlCommandReaderTest/034_setAirplaneMode_optional.yaml

@@ -0,0 +1,6 @@
+appId: com.example.app
+---
+- setAirplaneMode:
+    value: enabled
+    label: "Maybe enable airplane mode"
+    optional: true