Skip to content

Conversation

@lluiscampos
Copy link
Member

@lluiscampos lluiscampos commented Jan 14, 2026

No description provided.

@lluiscampos lluiscampos requested a review from a team as a code owner January 14, 2026 12:34
@mender-test-bot
Copy link

@lluiscampos, start a full client pipeline with:

  • mentioning me and start client pipeline

my commands and options

You can prevent me from automatically starting CI pipelines:

  • if your pull request title starts with "[NoCI] ..."

You can trigger a client pipeline on multiple prs with:

  • mentioning me and start client pipeline --pr mender/127 --pr mender-connect/255

You can trigger GitHub->GitLab branch sync with:

  • mentioning me and sync

You can cherry pick to a given branch or branches with:

  • mentioning me and:
 cherry-pick to:
 * 1.0.x
 * 2.0.x

@lluiscampos
Copy link
Member Author

@lluiscampos, start a full client pipeline with:

* mentioning me and `start client pipeline`

my commands and options

@mender-test-bot Yes, let's dry run this before calling the 🏇

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-2262435865

Build Configuration Matrix

Key Value
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/2375/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

@lluiscampos lluiscampos force-pushed the MEN-9236-cleanup-golang branch from 54f45cf to 8e91aa3 Compare January 14, 2026 19:20
@lluiscampos
Copy link
Member Author

@mender-test-bot start client pipeline

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-2263327914

Build Configuration Matrix

Key Value
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/2375/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

@lluiscampos lluiscampos force-pushed the MEN-9236-cleanup-golang branch 2 times, most recently from c449b9c to 3c56819 Compare January 16, 2026 10:58
@lluiscampos
Copy link
Member Author

@mender-test-bot start pipeline 🔎

@lluiscampos
Copy link
Member Author

@mender-test-bot start client pipeline 🔎

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-2266942201

Build Configuration Matrix

Key Value
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/2375/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

@lluiscampos lluiscampos force-pushed the MEN-9236-cleanup-golang branch 4 times, most recently from ffa2ad1 to 98ccd61 Compare January 21, 2026 07:05
@lluiscampos
Copy link
Member Author

@mender-test-bot start client pipeline

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-2275814074

Build Configuration Matrix

Key Value
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/2375/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

@lluiscampos
Copy link
Member Author

Note to reviewers,

This PR has been triggering a race condition in our tests in which test_uboot_compile breaks when running a read-only command to figure decide if it would run or skip. That is a long story. I launched a PR to address this at #2382

However by addressing it, it revealed that the test (that for long has not run) had outdated expectations, which are addressed at #2385

Now the original PR (this one) will pass with the #2385 alone, but still I will follow-up merging #2382 to be more future ready (hopefully it fixed the race condition, but it is not possible to prove...)

@lluiscampos lluiscampos changed the title MEN-9236: Remove support for testing golang client QA-1453: Remove support for testing golang client Jan 21, 2026
@lluiscampos
Copy link
Member Author

Note to self,

Update JIRA ticket reference after review

Copy link
Contributor

@danielskinstad danielskinstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lluiscampos
Copy link
Member Author

Now the original PR (this one) will pass with the #2385 alone, (...)

It didn't! So we'll get #2382 first

Ticket: QA-1453

Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
See:
* mendersoftware/mender-image-tests@7f390bf

Ticket: QA-1453

Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
@lluiscampos lluiscampos force-pushed the MEN-9236-cleanup-golang branch from 98ccd61 to dd2d1eb Compare January 21, 2026 15:13
@lluiscampos
Copy link
Member Author

@mender-test-bot start client pipeline 🤞

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-2276852801

Build Configuration Matrix

Key Value
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/2375/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
@elkoniu
Copy link
Contributor

elkoniu commented Jan 23, 2026

I think it would be useful to mention in the commit message which range of versions were golang based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants