-
Notifications
You must be signed in to change notification settings - Fork 212
QA-1453: Remove support for testing golang client #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
QA-1453: Remove support for testing golang client #2375
Conversation
|
@lluiscampos, start a full client pipeline with:
my commands and optionsYou can prevent me from automatically starting CI pipelines:
You can trigger a client pipeline on multiple prs with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
@mender-test-bot Yes, let's dry run this before calling the 🏇 |
|
Hello 😺 I created a pipeline for you here: Pipeline-2262435865 Build Configuration Matrix
|
54f45cf to
8e91aa3
Compare
|
@mender-test-bot start client pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-2263327914 Build Configuration Matrix
|
c449b9c to
3c56819
Compare
|
@mender-test-bot start pipeline 🔎 |
|
@mender-test-bot start client pipeline 🔎 |
|
Hello 😺 I created a pipeline for you here: Pipeline-2266942201 Build Configuration Matrix
|
ffa2ad1 to
98ccd61
Compare
|
@mender-test-bot start client pipeline |
|
Hello 😺 I created a pipeline for you here: Pipeline-2275814074 Build Configuration Matrix
|
|
Note to reviewers, This PR has been triggering a race condition in our tests in which However by addressing it, it revealed that the test (that for long has not run) had outdated expectations, which are addressed at #2385 Now the original PR (this one) will pass with the #2385 alone, but still I will follow-up merging #2382 to be more future ready (hopefully it fixed the race condition, but it is not possible to prove...) |
|
Note to self, Update JIRA ticket reference after review |
danielskinstad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Ticket: QA-1453 Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
See: * mendersoftware/mender-image-tests@7f390bf Ticket: QA-1453 Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
98ccd61 to
dd2d1eb
Compare
|
@mender-test-bot start client pipeline 🤞 |
|
Hello 😺 I created a pipeline for you here: Pipeline-2276852801 Build Configuration Matrix
|
|
I think it would be useful to mention in the commit message which range of versions were golang based. |
No description provided.