fix(ci): prevent suggestion over-application and duplicate comments#1557
Open
worktrunk-bot wants to merge 2 commits intomainfrom
Open
fix(ci): prevent suggestion over-application and duplicate comments#1557worktrunk-bot wants to merge 2 commits intomainfrom
worktrunk-bot wants to merge 2 commits intomainfrom
Conversation
Two behavioral issues from this hour's runs: 1. Bot used Edit to replace 3 lines with 1 when a GitHub suggestion only asked to change one word on one line (run 23129611560 on PR #1548). Add guidance to apply suggestions with exact scope. 2. Two concurrent claude-mention runs both commented on PR #1281 within 17 seconds (runs 23129315322, 23129320855). Add a dedup check before posting comments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
worktrunk-bot
added a commit
that referenced
this pull request
Mar 16, 2026
…ling Recurrence #3 of #1350 / #1430. The review-pr skill directed bots to "skip to step 5" for silent self-authored PRs, but step 5 had no skip condition — so bots entered 10-minute CI polling loops that add no value (no approval to dismiss on failure). Fix: redirect self-authored silent verdicts to step 6 (resolve threads) and add an explicit early-return at the top of step 5. Evidence from runs 23131628298 and 23130657242: both spent ~10 minutes polling CI on self-authored PRs #1558 and #1557 respectively, with no action possible on the results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
max-sixty
reviewed
Mar 16, 2026
Comment on lines
+106
to
+116
| ## Applying GitHub Suggestions | ||
|
|
||
| When a reviewer posts a GitHub suggestion (`suggestion` code block), apply it | ||
| with exact scope — change only the lines the suggestion covers. Do not | ||
| reinterpret the suggestion's intent or extend it to adjacent lines. Use the | ||
| `Edit` tool with an `old_string` that matches **only** the lines the suggestion | ||
| targets, not surrounding context. | ||
|
|
||
| If the suggestion seems incomplete or you think more lines should change, apply | ||
| the literal suggestion first and note the potential further improvement in your | ||
| reply. |
Collaborator
Author
There was a problem hiding this comment.
Shortened — dropped the Edit tool sentence (implementation detail, not behavioral guidance) and tightened the fallback line. Down from 7 content lines to 5.
Comment on lines
+120
to
+129
| Before posting a comment, check for recent bot comments on the same | ||
| PR/issue to avoid duplicates from concurrent runs: | ||
|
|
||
| ```bash | ||
| gh api repos/{owner}/{repo}/issues/{number}/comments \ | ||
| --jq '.[] | select(.user.login == "{bot_login}") | {id, created_at, body: (.body | .[0:100])}' | ||
| ``` | ||
|
|
||
| If you already commented on the same topic within the last 5 minutes, do not | ||
| post again. |
Owner
There was a problem hiding this comment.
to what extent does this duplicate existing guidance?
Collaborator
Author
There was a problem hiding this comment.
The review-pr skill has dedup logic, but it's specific to flaky test issue comments (editing an existing bot comment on a tracking issue). This one targets a different scenario: concurrent claude-mention runs both responding to the same issue_comment event and posting near-identical PR comments seconds apart.
That said, if you think the pattern is general enough that skills should just know to check, happy to drop this and rely on convention.
Drop implementation detail about Edit tool and tighten wording. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
worktrunk-bot
commented
Mar 16, 2026
Collaborator
Author
worktrunk-bot
left a comment
worktrunk-bot
left a comment
There was a problem hiding this comment.
Both additions are well-motivated and clearly written. One concern with the dedup check — see inline.
Comment on lines
+120
to
+123
| ```bash | ||
| gh api repos/{owner}/{repo}/issues/{number}/comments \ | ||
| --jq '.[] | select(.user.login == "{bot_login}") | {id, created_at, body: (.body | .[0:100])}' | ||
| ``` |
Collaborator
Author
There was a problem hiding this comment.
The issues API returns comments oldest-first by default. Without --paginate, only the first 30 are returned — on a busy PR, a bot comment from 2 minutes ago won't appear. Consider fetching only the tail:
Suggested change
| ```bash | |
| gh api repos/{owner}/{repo}/issues/{number}/comments \ | |
| --jq '.[] | select(.user.login == "{bot_login}") | {id, created_at, body: (.body | .[0:100])}' | |
| ``` | |
| ```bash | |
| gh api repos/{owner}/{repo}/issues/{number}/comments \ | |
| --jq '[.[] | select(.user.login == "{bot_login}")] | last | {id: .url, created_at: .created_at, body: (.body | .[0:100])}' |
Using `last` on the full paginated result works, but `--paginate` is slow on busy PRs. An alternative: `?sort=created&direction=desc&per_page=5` to fetch only the 5 most recent comments, then filter for the bot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two behavioral issues observed in this hour's Claude CI sessions:
1. Suggestion over-application (run 23129611560)
On PR #1548, max-sixty posted a GitHub suggestion that changed one word on one line (dropping "bot-authored" from "scan other open bot-authored PRs"). The bot used the
Edittool to replace three lines with one — deleting two follow-up lines ("If another PR touches the same files...") that the suggestion didn't cover. The bot treated the suggestion as "condense the paragraph" rather than applying the literal one-line edit.Fix: Add "Applying GitHub Suggestions" section to running-in-ci requiring exact-scope edits — change only lines the suggestion covers, not surrounding context.
2. Duplicate comments from concurrent runs (runs 23129315322 + 23129320855)
Two claude-mention runs triggered by the same
issue_commentevent both posted near-identical comments on PR #1281 — 17 seconds apart (05:30:28 and 05:30:45 UTC). Both responded to max-sixty's question about remote URL approaches for bare repos.Fix: Add a dedup check to the "Replying to Comments" section — check for recent bot comments before posting. Similar to the review-pr fix in #1490.
Other sessions reviewed (no issues)
🤖 Generated with Claude Code