fix(review-pr): stop CI polling on self-authored PRs (recurrence #3)#1560
Closed
worktrunk-bot wants to merge 1 commit intomainfrom
Closed
fix(review-pr): stop CI polling on self-authored PRs (recurrence #3)#1560worktrunk-bot wants to merge 1 commit intomainfrom
worktrunk-bot wants to merge 1 commit intomainfrom
Conversation
…ling Recurrence #3 of #1350 / #1430. The review-pr skill directed bots to "skip to step 5" for silent self-authored PRs, but step 5 had no skip condition — so bots entered 10-minute CI polling loops that add no value (no approval to dismiss on failure). Fix: redirect self-authored silent verdicts to step 6 (resolve threads) and add an explicit early-return at the top of step 5. Evidence from runs 23131628298 and 23130657242: both spent ~10 minutes polling CI on self-authored PRs #1558 and #1557 respectively, with no action possible on the results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The skill text in Step 4 said "stay silent and skip to step 5" for self-authored PRs. But Step 5 had no skip condition for self-authored PRs — it just said "After approving or staying silent, monitor CI." The bot dutifully entered a 10-minute polling loop every time, despite having no approval to dismiss on failure.
Previous fixes (#1350, #1430) added skip instructions but they were either too subtle or placed only at Step 5's entry without also fixing the Step 4 redirect. This fix addresses both locations.
Evidence
Test plan
🤖 Generated with Claude Code