Fix PX4 log upload auto-upload state inconsistency#14237
Merged
DonLakeFlyer merged 1 commit intomavlink:masterfrom Mar 29, 2026
Merged
Fix PX4 log upload auto-upload state inconsistency#14237DonLakeFlyer merged 1 commit intomavlink:masterfrom
DonLakeFlyer merged 1 commit intomavlink:masterfrom
Conversation
Contributor
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 4 passed, 32 failed, 7 skipped. Test Resultslinux-sanitizers: 67 passed, 0 skipped Artifact Sizes
|
When saveItems() unchecks autoUploadCheck due to an empty email address, also set _mavlinkLogManager.enableAutoUpload = false so the backend state stays in sync with the UI. Partial fix for mavlink#14218 (item 4).
DonLakeFlyer
force-pushed
the
fix/px4-log-upload-state-sync
branch
from
e882e53 to
eddb7c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #14218 (item 4).
Problem
In
PX4LogUploadSettings.qml,saveItems()unchecksautoUploadCheckwhen the email address is empty, but never sets_mavlinkLogManager.enableAutoUpload = false. This leaves the backend auto-upload enabled while the UI shows it disabled.Fix
Add
_mavlinkLogManager.enableAutoUpload = falsein the empty-email branch so the manager state stays in sync with the checkbox.