Skip to content

Commit eddb7c6

Browse files
committed
Fix PX4 log upload auto-upload state inconsistency
When saveItems() unchecks autoUploadCheck due to an empty email address, also set _mavlinkLogManager.enableAutoUpload = false so the backend state stays in sync with the UI. Partial fix for #14218 (item 4).
1 parent 33d4627 commit eddb7c6

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/UI/AppSettings/PX4LogUploadSettings.qml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ SettingsGroupLayout {
2626
_mavlinkLogManager.uploadURL = urlField.text
2727
if (autoUploadCheck.checked && _mavlinkLogManager.emailAddress === "") {
2828
autoUploadCheck.checked = false
29+
_mavlinkLogManager.enableAutoUpload = false
2930
} else {
3031
_mavlinkLogManager.enableAutoUpload = autoUploadCheck.checked
3132
}
@@ -198,8 +199,9 @@ SettingsGroupLayout {
198199
checked: _mavlinkLogManager ? _mavlinkLogManager.enableAutoUpload : false
199200
enabled: !_disableDataPersistence
200201
onClicked: {
202+
const wantsAutoUpload = checked
201203
saveItems()
202-
if (checked && _mavlinkLogManager.emailAddress === "")
204+
if (wantsAutoUpload && _mavlinkLogManager && _mavlinkLogManager.emailAddress === "")
203205
emptyEmailDialog.open()
204206
}
205207
}

0 commit comments

Comments
 (0)