Skip to content

Add DownloadGeofence RPC to geofence proto#400

Merged
julianoes merged 1 commit intomavlink:mainfrom
PavelGuzenfeld:fix/2403-download-geofence
Mar 30, 2026
Merged

Add DownloadGeofence RPC to geofence proto#400
julianoes merged 1 commit intomavlink:mainfrom
PavelGuzenfeld:fix/2403-download-geofence

Conversation

@PavelGuzenfeld
Copy link
Copy Markdown
Contributor

@PavelGuzenfeld PavelGuzenfeld commented Mar 21, 2026

Summary

  • Add DownloadGeofence RPC to GeofenceService
  • Add DownloadGeofenceRequest and DownloadGeofenceResponse messages

Motivation

Fixes mavlink/MAVSDK#2403

Companion PR

mavlink/MAVSDK#2804

Test Results

  • Proto compiles cleanly (clean Debug build)
  • Unit tests 289/289 pass
  • PX4 SITL round-trip: upload polygon+circle, download back, all data matches

message SubscribeHomeRequest {}
message HomeResponse {
Position home = 1; // The next home position
HomePosition home = 1; // The next home position
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this breaks the API/ABI and would have to come with a major version bump.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — pulled the telemetry stuff out into its own PR (#401). This one's just the geofence bits now.

Add DownloadGeofence RPC with DownloadGeofenceRequest/Response messages
to enable downloading polygon and circular geofences from the vehicle.

Fixes mavlink/MAVSDK#2403
@julianoes julianoes merged commit 1da8975 into mavlink:main Mar 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing function download_geofence

2 participants