Conversation
|
Thank you for the contribution. |
|
@makiuchi-d not for the datamatrix. I implemented the minimal encoder, like you suggested. I couldn't find an actual prepend for the code128 in the original ZXing. Do you need me to remove it? If anything else needs to change let me know! |
|
@makiuchi-d i removed the code128 changes as they are not mirroring ZXing's implementation. |
|
@gijsbotje |
…re, fix encoded character handling
|
I added some tests and fixed a bug in how character encoding is handled. The HighLevelEncoder naming (which I wrote) wasn’t very consistent either, but I fixed some inconsistent naming in MinimalEncoder. Was that written by AI, by any chance? I’ll add a few more tests and plan to merge if everything looks good. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 97.93% 96.37% -1.56%
==========================================
Files 122 126 +4
Lines 12951 11352 -1599
==========================================
- Hits 12684 10941 -1743
- Misses 191 291 +100
- Partials 76 120 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@makiuchi-d anything I can do to help? |
|
@gijsbotje If possible, it would really help if you could also port GS1 support for DataMatrixReader so we can cross-verify with the Writer. |
|
@makiuchi-d i've tried adding the support and added a test with the image from my initial comment. Hopefully it's all correct :) |
|
@makiuchi-d anything else i can do to help you out on this? |
As #42 has been stale for years, this adds support for the GS1 hints used by the minimal encoder as implemented in zxing.
Validated using https://play.google.com/store/apps/details?id=com.chaniotisalexandros.gs1barcodescanner and generating the barcodes below using our API.
content in human-readable format:
Before:

After:
