Skip to content

datamatrix: first FNC1 as ascii 232#42

Open
mutm wants to merge 1 commit intomakiuchi-d:masterfrom
mutm:master
Open

datamatrix: first FNC1 as ascii 232#42
mutm wants to merge 1 commit intomakiuchi-d:masterfrom
mutm:master

Conversation

@mutm
Copy link
Copy Markdown

@mutm mutm commented Apr 24, 2021

To support GS1 Datamatrix format

To support GS1 Datamatrix format
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 24, 2021

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@makiuchi-d
Copy link
Copy Markdown
Owner

makiuchi-d commented Apr 30, 2021

Thank you for your contribution.

IMO, it should be indicated by EncodeHintType_GS1_FORMAT rather than a charactor \u00e8.
And it need to implement the decoder support.

I want it be implemented on the original ZXing before this repository.

@gijsbotje
Copy link
Copy Markdown

@makiuchi-d looks like zxing has support for this since Jan 12, 2022, can this be merged?

@makiuchi-d
Copy link
Copy Markdown
Owner

@gijsbotje
Thank you for pointing this out.

I may be missing something, but I don’t see a corresponding implementation in the original ZXing code for this change.
https://github.com/zxing/zxing/blob/50799640d5c4d6cd85f75f047a3055d05485fae5/core/src/main/java/com/google/zxing/datamatrix/encoder/HighLevelEncoder.java#L41-L44

Could you please let me know where this is implemented in ZXing?

@gijsbotje
Copy link
Copy Markdown

@makiuchi-d It seems to be in the minimalEncoder in the zxing repo. The GS1_FORMAT is checked in the DatamarixWriter at:
https://github.com/zxing/zxing/blob/50799640d5c4d6cd85f75f047a3055d05485fae5/core/src/main/java/com/google/zxing/datamatrix/DataMatrixWriter.java#L92

And passed to a minimalEncoder when hasCompactionHint is true, at:
https://github.com/zxing/zxing/blob/50799640d5c4d6cd85f75f047a3055d05485fae5/core/src/main/java/com/google/zxing/datamatrix/DataMatrixWriter.java#L100

I might have misunderstood how this works in the original library as i'm neither a go or java deleloper.

@makiuchi-d
Copy link
Copy Markdown
Owner

@gijsbotje Thanks for checking this in detail.
As you showed, in the original ZXing it is implemented in a completely different way.
We will need to port the entire MinimalEncoder and its related code.

@gijsbotje
Copy link
Copy Markdown

gijsbotje commented Dec 29, 2025

@makiuchi-d i've implemented the minimalEncoder in #78 and made a few other changes to make work more like the java implemetation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants