Conversation
To support GS1 Datamatrix format
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Thank you for your contribution. IMO, it should be indicated by I want it be implemented on the original ZXing before this repository. |
|
@makiuchi-d looks like zxing has support for this since Jan 12, 2022, can this be merged? |
|
@gijsbotje I may be missing something, but I don’t see a corresponding implementation in the original ZXing code for this change. Could you please let me know where this is implemented in ZXing? |
|
@makiuchi-d It seems to be in the minimalEncoder in the zxing repo. The GS1_FORMAT is checked in the DatamarixWriter at: And passed to a minimalEncoder when hasCompactionHint is true, at: I might have misunderstood how this works in the original library as i'm neither a go or java deleloper. |
|
@gijsbotje Thanks for checking this in detail. |
|
@makiuchi-d i've implemented the minimalEncoder in #78 and made a few other changes to make work more like the java implemetation. |
To support GS1 Datamatrix format