Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bexxmodd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🔥 🌟 nits/nice to have (non blocker)
|
| # Feature definitions for the wizard: id and label match v1.4 conformance table columns | ||
| # https://gateway-api.sigs.k8s.io/implementations/v1.4/ | ||
| FEATURE_DEFINITIONS = { | ||
| "httpGateway": [ |
There was a problem hiding this comment.
more of a todo: will be worth getting the ids and labels generated rather than hard coded
There was a problem hiding this comment.
Idk exactly how to do it. Feature names are not as descriptive in reports, so hard coded for later parsing.
Feel free to propose something
There was a problem hiding this comment.
might be able to just get the label from the id, adding a space between the words. But this is not a blocker, so can be done in a later pr 👍
| for the Controller Recommendation Wizard. Supports --all (one object keyed by version) or | ||
| --version vX.Y.Z (single array for that version). Output path defaults to | ||
| site-src/wizard/data/controller-wizard-data.json. The output directory is created if it does not exist. | ||
| """ |
There was a problem hiding this comment.
so the version that lives on the website will be probably the most recent version? the version flag will have to be manually set to generate the json file - maybe we should make grabbing the version more automated? 🤔 this can be done manually for now
There was a problem hiding this comment.
Just updated the mkdocs. So on each run, a new version will be grabbed, and the data will be generated for the latest three versions
| <p id="version-row"> | ||
| <label for="version-select"><strong>Gateway API version:</strong></label> | ||
| <select id="version-select"></select> | ||
| </p> |
There was a problem hiding this comment.
Can we make this a "min version" instead of ==
There was a problem hiding this comment.
Version selection allows us to cleanly filter features and conformance reports. It's a redesign of how recommendation functions (including the data generation script) if users select min version instead of a specific one.
Co-authored-by: Rob Scott <rob.scott87@gmail.com>
|
…med recommend to match.
| return | ||
| } | ||
|
|
||
| must, good := getSelections() |
There was a problem hiding this comment.
We may want to consider the deployment of the gateway. For example, if I am on AWS I cannot use GKE so its a bad recommendation. Likewise, if I don't want to pay a vendor I may need an open source implementation,
There was a problem hiding this comment.
While I see the potential usefulness of this, I think we want to limit the inputs to what's in conformance reports. Given the relatively small proportion of implementations from Cloud Providers, I'd expect this to be pretty easy to filter out/manually ignore when looking at the results.
There was a problem hiding this comment.
Have to agree with Rob. That seems a good evolution of the wizard, but that will require tying that information to conformance, as those reports serve source of truth for what the wizard shows
What type of PR is this?
/kind documentation
What this PR does / why we need it:
It's a controller matching wizard for the providers that submitted conformance reports. This should simplify operator/controller selection compared to peeking at the table's features.
You can run this by and test it locally at (http://localhost:8080/index.html):
Probably many things will require adjustment before this can be hosted, but it's good enough to try it locally for the initial feedback.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: