chore: enable auth in the production manifests#958
Open
christian-heusel wants to merge 1 commit intokubeflow:notebooks-v2from
Open
chore: enable auth in the production manifests#958christian-heusel wants to merge 1 commit intokubeflow:notebooks-v2from
christian-heusel wants to merge 1 commit intokubeflow:notebooks-v2from
Conversation
For the production manifests:
$ kustomize build workspaces/backend/manifests/kustomize/overlays/istio/ | grep -iA1 DISABLE_AUTH
- name: DISABLE_AUTH
value: "false"
For the tilt setup:
$ kubectl get deployments -n kubeflow-workspaces workspaces-backend -o yaml | grep -iA1 DISABLE_AUTH
- name: DISABLE_AUTH
value: "true"
Signed-off-by: Christian Heusel <christian@heusel.eu>
Author
|
/retest |
Author
|
/ok-to-test |
google-oss-prow
bot
added
ok-to-test
area/backend
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
christian-heusel
force-pushed
the
chore/enable-auth-manifests
branch
from
078d3bd to
bf7e469
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the production manifests:
For the tilt setup: