Skip to content

Commit bf7e469

Browse files
chore: Enable auth in the production manifests
For the production manifests: $ kustomize build workspaces/backend/manifests/kustomize/overlays/istio/ | grep -iA1 DISABLE_AUTH - name: DISABLE_AUTH value: "false" For the tilt setup: $ kubectl get deployments -n kubeflow-workspaces workspaces-backend -o yaml | grep -iA1 DISABLE_AUTH - name: DISABLE_AUTH value: "true" Signed-off-by: Christian Heusel <christian@heusel.eu>
1 parent 697ffd7 commit bf7e469

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

developing/Tiltfile

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,20 @@ for o in backend_objects:
9393
"SWAGGER_ENABLED": "true",
9494
"SWAGGER_SCHEME": "https",
9595
"SWAGGER_HOST": "localhost:8443",
96-
"SWAGGER_BASE_PATH": "/workspaces/api/v1"
96+
"SWAGGER_BASE_PATH": "/workspaces/api/v1",
97+
"DISABLE_AUTH": "true",
9798
}
99+
100+
# Replace existing keys and add missing ones
101+
for (i, var) in enumerate(env):
102+
key = var["name"]
103+
if key in tilt_env_vars.keys():
104+
env[i] = {
105+
"name": key,
106+
"value": tilt_env_vars[key],
107+
}
108+
tilt_env_vars.pop(key)
109+
98110
for (key, value) in tilt_env_vars.items():
99111
env.append({
100112
"name": key,

workspaces/backend/manifests/kustomize/base/deployment.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ spec:
3434
env:
3535
- name: PORT
3636
value: "4000"
37+
# TODO: remove before GA
38+
- name: DISABLE_AUTH
39+
value: "false"
3740
resources:
3841
limits:
3942
cpu: 1

0 commit comments

Comments
 (0)