Use size_t for View indices to prevent potential integer overflow#75
Merged
Use size_t for View indices to prevent potential integer overflow#75
Conversation
8be4de9 to
33695a0
Compare
Change loop indices from int to size_t when accessing 2D Views in stats.cpp and io.cpp to prevent potential integer overflow when the total number of elements exceeds INT_MAX.
33695a0 to
e6135d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inttosize_twhen accessing 2D Views instats.cppandio.cppINT_MAXChanges
stats.cpp: Usesize_tfor indicesiandjincorrcoef(CrossMap, Dataset, TimeSeries)io.cpp: Usesize_tforn_rows,n_columns, and loop indices inload_csv()Test plan