Merge pull request #75 from keichi/fix-int-overflow-indices

Use size_t for View indices to prevent potential integer overflow

Author: keichi

src/io.cpp

@@ -21,9 +21,9 @@ Dataset load_csv(const std::string &path)
         throw std::invalid_argument("Failed to open file " + path);
     }
 
-    auto n_rows = 0;
-    auto n_columns = 0;
-    auto is_header = true;
+    size_t n_rows = 0;
+    size_t n_columns = 0;
+    bool is_header = true;
 
     while (ifs >> line) {
         std::stringstream ss(line);
@@ -51,8 +51,8 @@ Dataset load_csv(const std::string &path)
     auto ds = MutableDataset("dataset", n_rows, n_columns);
     auto mirror = Kokkos::create_mirror_view(ds);
 
-    for (auto i = 0; i < n_columns; i++) {
-        for (auto j = 0; j < n_rows; j++) {
+    for (size_t i = 0; i < n_columns; i++) {
+        for (size_t j = 0; j < n_rows; j++) {
             mirror(j, i) = columns[i][j];
         }
     }

src/stats.cpp

@@ -23,13 +23,13 @@ void corrcoef(CrossMap rho, Dataset ds, TimeSeries x)
         "EDM::stats::corrcoef",
         Kokkos::TeamPolicy<>(ds.extent(1), Kokkos::AUTO),
         KOKKOS_LAMBDA(const Kokkos::TeamPolicy<>::member_type &member) {
-            const int j = member.league_rank();
+            const size_t j = member.league_rank();
             CorrcoefSimpleState state;
 
             Kokkos::parallel_reduce(
                 Kokkos::TeamThreadRange(member,
                                         Kokkos::min(x.extent(0), ds.extent(0))),
-                [=](int i, CorrcoefSimpleState &upd) {
+                [=](size_t i, CorrcoefSimpleState &upd) {
                     upd += CorrcoefSimpleState(x(i), ds(i, j));
                 },
                 Kokkos::Sum<CorrcoefSimpleState>(state));