Skip to content

Replace @flaky.flaky decorate with pytest marker #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Carreau merged 1 commit into from
Oct 16, 2025
Merged

Replace @flaky.flaky decorate with pytest marker #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/exporters/test_qtpng.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import os

import pytest
from flaky import flaky

from nbconvert.exporters.qt_screenshot import QT_INSTALLED
from nbconvert.exporters.qtpng import QtPNGExporter
Expand All @@ -20,7 +19,7 @@ class TestQtPNGExporter(ExportersTestsBase):

exporter_class = QtPNGExporter # type:ignore

@flaky
@pytest.mark.flaky()
def test_export(self):
"""
Can a TemplateExporter export something?
Expand Down
3 changes: 1 addition & 2 deletions tests/test_nbconvertapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import nbformat
import pytest
from flaky import flaky # type:ignore
from traitlets.tests.utils import check_help_all_output

from nbconvert.exporters import HTMLExporter
Expand Down Expand Up @@ -150,7 +149,7 @@ def test_filename_spaces(self):
)
assert os.path.isfile("notebook with spaces.pdf")

@flaky
@pytest.mark.flaky()
@pytest.mark.network()
@pytest.mark.skipif(not PLAYWRIGHT_INSTALLED, reason="Playwright not installed")
def test_webpdf_with_chromium(self):
Expand Down
Loading