Replace @flaky.flaky decorate with pytest marker

[mgorny]

Use the @pytest.mark.flaky marker in place of the @flaky.flaky decorator, to modernize the code and improve compatibility with other plugins providing the feature such as pytest-rerunfailures.

[Carreau]

Sounds great; Thanks for this, I'm going to merge, it would be good if you can link to some docs listing the advantage of this and pytest-rerunfailures vs using flaky directly.

[mgorny]

Sounds great; Thanks for this, I'm going to merge, it would be good if you can link to some docs listing the advantage of this and pytest-rerunfailures vs using flaky directly.

I'm afraid I don't know of anything specific. The rough idea is that if you import flaky, then you must use flaky, but if you use the marker you can use any plugin that implements that marker — so probably the most relevant docs are the docs of different plugins implementing the marker.

As for why pytest-rerunfailures, it's pretty arbitrary. It's just that we've happened to hit packages that requires pytest-rerunfailures specifically and failed when flaky was enabled (sorry, don't recall which exactly), but worked the other way around.