Fix flash variable case inconsistency in rp2040.mk#52
Closed
Copilot wants to merge 2 commits into49-menu-items-on-esp32-not-workingfrom
Closed
Fix flash variable case inconsistency in rp2040.mk#52Copilot wants to merge 2 commits into49-menu-items-on-esp32-not-workingfrom
Copilot wants to merge 2 commits into49-menu-items-on-esp32-not-workingfrom
Conversation
Merged
Co-authored-by: jscrane <668422+jscrane@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on renaming menu variables
Fix flash variable case inconsistency in rp2040.mk
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rp2040.mkimplementation was using$(FLASH)in uppercase on lines 35-36 while checking forflashin lowercase on line 1 and using lowercase for all other menu variables. This created a mismatch where the variable was checked but never properly referenced.Changes:
$(FLASH)to$(flash)inFS_STARTandFS_SIZEvariable assignments (rp2040.mk:35-36)flash := 8388608_0(docs/rp2040.md:35)Now consistent with the lowercase convention used for all other menu variables:
freq,opt,rtti,stackprotect,exceptions,dbgport,dbglvl,boot2,usbstack,ipbtstack,uploadmethod.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.