Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request aims to rename menu variables across the codebase to match the naming conventions used in Arduino board definitions. The changes update the hardware.mk logic to remove automatic uppercase conversion of menu variable names, update the esp32.mk file to use PascalCase naming, and update documentation across multiple platforms.
Changes:
- Modified hardware.mk to remove uppercase conversion logic and reorder menu variable processing
- Updated esp32.mk menu variables from UPPERCASE to PascalCase (e.g., JTAGADAPTER → JTAGAdapter)
- Updated documentation for multiple platforms to reflect lowercase/mixed-case menu variable names
- Added menu-variables debug target, changed pcregrep to pcre2grep, and added BOARD preprocessor macro
- Updated README.md with new version numbers for esp32 and rp2040 cores
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| hardware.mk | Simplified menu variable processing by removing uppercase conversion and moved menu definitions earlier in the file |
| esp32.mk | Renamed all menu variables from UPPERCASE to PascalCase to match board definition naming |
| docs/stm32.md | Updated menu variable names to lowercase in documentation |
| docs/rp2040.md | Updated menu variable names to lowercase and added new menu options |
| docs/esp.md | Updated menu variable names - lowercase for esp8266, PascalCase for esp32 |
| docs/avr.md | Updated menu variable names to lowercase in documentation |
| build-targets.mk | Added menu-variables target, changed pcregrep to pcre2grep, and added -DBOARD macro to CPPFLAGS |
| README.md | Updated supported core versions for esp32 (2.0.17 → 3.3.7) and rp2040 (4.1.1 → 5.4.4), removed Energia references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
Owner
Author
|
@copilot please just review this pr again. do NOT start another pr yourself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check other cores' menu names.