Skip to content

Fixes pre-commit#4901

Merged
kellyguo11 merged 1 commit intoisaac-sim:developfrom
myurasov-nv:my-fix-pre-commit
Mar 10, 2026
Merged

Fixes pre-commit#4901
kellyguo11 merged 1 commit intoisaac-sim:developfrom
myurasov-nv:my-fix-pre-commit

Conversation

@myurasov-nv
Copy link
Collaborator

Just that, fixes pre-commit stumbling on action.yaml.

@github-actions github-actions bot added bug Something isn't working infrastructure labels Mar 10, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 10, 2026

Greptile Summary

This PR removes a single trailing whitespace character from a blank line in .github/actions/ecr-build-push-pull/action.yml, fixing a pre-commit lint failure. There are no functional or behavioral changes.

  • Trailing space on the blank line following the echo "🟢 ECR_CACHE_URL env var not set, trying SSM..." statement (line 65) was removed to satisfy the pre-commit trailing-whitespace hook.
  • The ECR URL resolution logic, Docker build/push steps, and all other behavior remain completely unchanged.

Confidence Score: 5/5

  • This PR is safe to merge — it is a pure whitespace cleanup with zero functional impact.
  • The only change is the removal of a trailing space from a blank line inside a shell script embedded in a GitHub Actions composite action. No logic, no commands, and no behavior are altered.
  • No files require special attention.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Start: ECR Build-Push-Pull Action] --> B{ecr-url input set?}
    B -- Yes --> E[Use input ECR URL]
    B -- No --> C{ECR_CACHE_URL env var set?}
    C -- Yes --> E
    C -- No --> D[Query IMDS for Instance ID & Region]
    D --> F{Instance ID found?}
    F -- No --> G[Skip SSM — not on EC2]
    F -- Yes --> H[Query SSM: /github-runner/instance-id/ecr-cache-url]
    H --> I{SSM param found?}
    I -- Yes --> E
    I -- No --> G
    G --> J{ECR URL resolved?}
    E --> J
    J -- No --> K[Build locally — no ECR cache]
    J -- Yes --> L[Login to ECR]
    L --> M{Image already in ECR?}
    M -- Yes --> N[Pull & tag — skip build]
    M -- No --> O[Build with ECR layer cache]
    O --> P[Push to ECR]
    K --> Q[Done]
    N --> Q
    P --> Q
Loading

Last reviewed commit: a1a43b2

@kellyguo11 kellyguo11 merged commit 581bfd5 into isaac-sim:develop Mar 10, 2026
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants