-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Adds environment tests for Newton #4862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b085ba7
1e73494
979dff1
40c742e
3ee03b8
3b4f48e
a876b2b
26c511e
73b3c87
fb6b6db
472736e
0e51e7b
9aada36
2ff0c7c
03f1056
5b35e9b
b7ad878
61e9346
155389b
96f5577
de5d1cd
500629f
393b486
58b7fc6
3a43d23
7b67566
f1f50e9
08c303f
689c420
1aae77c
644a671
90442e6
ed34c01
831c91b
9adb262
31f7b89
81d457d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,8 +48,9 @@ | |
| "body": ImplicitActuatorCfg( | ||
| joint_names_expr=[".*"], | ||
| stiffness=0.0, | ||
| damping=0.0, | ||
| effort_limit_sim=30.0, | ||
| damping=0.1, | ||
| armature=0.05, | ||
| effort_limit_sim=15.0, | ||
| ), | ||
| }, | ||
|
Comment on lines
48
to
55
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. actuators={
"body": ImplicitActuatorCfg(
joint_names_expr=[".*"],
stiffness=0.0,
damping=0.1,
armature=0.02,
effort_limit_sim=15.0,
),
}, |
||
| ) | ||
|
|
||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Joint ordering matters for humanoid: physx_joint_gears: list = [
67.5000, # lower_waist
67.5000, # lower_waist
67.5000, # right_upper_arm
67.5000, # right_upper_arm
67.5000, # left_upper_arm
67.5000, # left_upper_arm
67.5000, # pelvis
45.0000, # right_lower_arm
45.0000, # left_lower_arm
45.0000, # right_thigh: x
135.0000, # right_thigh: y
45.0000, # right_thigh: z
45.0000, # left_thigh: x
135.0000, # left_thigh: y
45.0000, # left_thigh: z
90.0000, # right_knee
90.0000, # left_knee
22.5, # right_foot
22.5, # right_foot
22.5, # left_foot
22.5, # left_foot
]
newton_joint_gears: list = [
67.5000, # left_upper_arm
67.5000, # left_upper_arm
45.0000, # left_lower_arm
67.5000, # lower_waist
67.5000, # lower_waist
67.5000, # pelvis
45.0000, # left_thigh: x
135.0000, # left_thigh: y
45.0000, # left_thigh: z
90.0000, # left_knee
22.5, # left_foot
22.5, # left_foot
45.0000, # right_thigh: x
135.0000, # right_thigh: y
45.0000, # right_thigh: z
90.0000, # right_knee
22.5, # right_foot
22.5, # right_foot
67.5000, # right_upper_arm
67.5000, # right_upper_arm
45.0000, # right_lower_arm
]
joint_gears = {
"physx": physx_joint_gears,
"newton": newton_joint_gears,
}
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is also needed in the locomotion env: # Resolve the joint gears based on the physics type, since they do not have the same joint ordering.
if isinstance(self.cfg.joint_gears, dict):
print(self.cfg.sim.physics)
if self.cfg.sim.physics.__class__.__name__ == "PhysxCfg":
joint_gears = self.cfg.joint_gears["physx"]
elif self.cfg.sim.physics.__class__.__name__ == "NewtonCfg":
joint_gears = self.cfg.joint_gears["newton"]
else:
raise ValueError(f"Invalid physics type: {self.cfg.sim.physics}")
else:
joint_gears = self.cfg.joint_gears
self.joint_gears = torch.tensor(joint_gears, dtype=torch.float32, device=self.sim.device) |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I could make the material API for newton, we've had that working in dev/newton. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not longer be needed with #4890.