Skip to content

Removes pinocchio flag from docs#4734

Merged
kellyguo11 merged 1 commit intoisaac-sim:developfrom
peterd-NV:peterd/update_mimic_docs
Feb 26, 2026
Merged

Removes pinocchio flag from docs#4734
kellyguo11 merged 1 commit intoisaac-sim:developfrom
peterd-NV:peterd/update_mimic_docs

Conversation

@peterd-NV
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 26, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Removed all occurrences of the deprecated --enable_pinocchio flag from command-line examples in the humanoids imitation learning documentation. This cleanup follows PR #4713 which removed legacy support for a custom-built version of pinocchio from the codebase, eliminating the need for the flag.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Documentation-only changes that remove a deprecated flag consistently across all examples, with no logical errors or implementation risks
  • No files require special attention

Important Files Changed

Filename Overview
docs/source/overview/imitation-learning/humanoids_imitation.rst Removed deprecated --enable_pinocchio flag from all command examples (19 occurrences) following removal of the flag in codebase

Last reviewed commit: 9c814ec

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@kellyguo11 kellyguo11 changed the title remove pinocchio from docs Removes pinocchio flag from docs Feb 26, 2026
@kellyguo11 kellyguo11 merged commit 6ffc311 into isaac-sim:develop Feb 26, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants