Fixes of camera test failures#4681
Draft
pascal-roth wants to merge 1 commit intoisaac-sim:developfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses failures in following tests
test_ray_caster_camera.pyandtest_multi_mesh_ray_caster_camera.pyfail in the comparison to the USD Camera, here the position of the USD camera is set viaset_world_poses_from_viewwhich calls the fabric backend. I can track in the usd that the pos and orientation is applied correctly but the position seems not correctly updated in the backend - camera remains at (0, 0, 0) at least judging its output. Generally the positions seem off, prev. test that described a mean depth of 2.7 now only reach 2.23 such as in the tiled camera test. ran the same tests with a prev IsaacSim version. Position, orientations, intrinsics, ... of the cameras are identical, as are the other configs, however mean depth reaches 2.73. In a different test I had to remove a set offset for it to succeed. -- SOMETHING IS REALLY OFF WITH THE POSITIONStest_tiled_camera.pyhas an issue with the cpu pipeline, the code randomly gets stuck, no error.test_multi_tiled_camera.pyis fixed - when updating the colors, I had to do sim.reset() to let it take effectType of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there