Skip to content

Comments

Add experiment name to be set correctly#4635

Merged
ooctipus merged 1 commit intoisaac-sim:mainfrom
ClemensSchwarke:fix/add_missing_arg
Feb 21, 2026
Merged

Add experiment name to be set correctly#4635
ooctipus merged 1 commit intoisaac-sim:mainfrom
ClemensSchwarke:fix/add_missing_arg

Conversation

@ClemensSchwarke
Copy link
Collaborator

Add the experiment_name CLI argument to update_rsl_rl_cfg(), as passing it didn't have any effect before.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@github-actions github-actions bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Feb 17, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 17, 2026

Greptile Summary

This PR fixes a bug where the --experiment_name CLI argument was being parsed but not applied to the agent configuration. The fix adds the missing two-line check in update_rsl_rl_cfg() to transfer the CLI argument value to the config object, following the exact same pattern used for all other CLI arguments in the function (like run_name, load_run, checkpoint, etc.).

Changes:

  • Adds conditional check to apply args_cli.experiment_name to agent_cfg.experiment_name when the CLI argument is provided
  • The fix is placed in the correct location (after checkpoint, before run_name), maintaining logical grouping of related arguments
  • Change matches the established code pattern and will ensure experiment logs are saved to the user-specified directory

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is a straightforward bug fix that adds two lines to handle a missing CLI argument. The code follows the exact pattern used for all other similar arguments in the same function, the fix is correctly placed, and there are no logical errors or edge cases to consider.
  • No files require special attention

Important Files Changed

Filename Overview
scripts/reinforcement_learning/rsl_rl/cli_args.py Adds missing experiment_name CLI argument handling to config update function. Follows existing pattern, fix is correct and complete.

Last reviewed commit: 2c78b7d

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

@AntoineRichard AntoineRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ooctipus ooctipus merged commit 80094be into isaac-sim:main Feb 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants