Switches to ruff in-built isort ordering#4377
Merged
Mayankm96 merged 6 commits intoisaac-sim:mainfrom Jan 14, 2026
Merged
Conversation
Mayankm96
requested review from
ClemensSchwarke,
Toni-SM,
hhansen-bdai,
jtigue-bdai,
kellyguo11,
masoudmoghani,
matthewtrepte,
ooctipus,
ossamaAhmed,
pascal-roth and
xyao-nv
as code owners
Contributor
|
Too many files changed for review. ( |
github-actions
bot
added
bug
jtigue-bdai
reviewed
Jan 13, 2026
| "isaaclab-rl", | ||
| "isaaclab-mimic", | ||
| "isaaclab-tasks", | ||
| "isaaclab-assets", |
Collaborator
There was a problem hiding this comment.
Is there a specific reason for putting assets ant the bottom?
Contributor
Author
There was a problem hiding this comment.
Assets only have pre-built configurations. It looked slightly cleaner to have those global objects in the end of the file (i.e. based on the order of their typical usage in the code).
from isaaclab_tasks.locomotion.velocity import VelocityEnvCfg
from isaaclab_assets.robots import DIGIT_CFG
cfg = VelocityEnvCfg()
cfg.scene.robot = DIGIT_CFG
nitesh-subedi
pushed a commit
to nitesh-subedi/IsaacLab
that referenced
this pull request
Feb 5, 2026
# Description Fixes isaac-sim#4336 ## Type of change - Breaking change (existing functionality will not work without user modification) - Documentation update ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4336
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there