-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Isaac Sim 6.0] Updates torch to 2.9.0+cu128 for x86 #4001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kellyguo11
merged 22 commits into
isaac-sim:feature/isaacsim-6-0
from
kellyguo11:update-torch
Nov 14, 2025
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
035abcc
Updates torch to 2.9.0+cu13
kellyguo11 91281c8
format
kellyguo11 aff982f
updates
kellyguo11 ab507fb
try base docker
kellyguo11 dc9e6be
update
kellyguo11 14d8fed
revert torch
kellyguo11 25de43a
revert docker
kellyguo11 1ddbce0
clean up doc
kellyguo11 a198e8f
update torch to 2.9.0
kellyguo11 66a35e7
Set ISAACSIM_ACCEPT_EULA environment variable
kellyguo11 ccec4a9
Simplify ISAAC Sim installation step
kellyguo11 bf81a38
Add tqdm and decorator dependencies
kellyguo11 f8ed9d8
Update default Dockerfile path in action.yml
kellyguo11 bfb2085
Clean up dependencies in setup.py
kellyguo11 0bd1f46
Update EULA acceptance variables in license-check.yaml
kellyguo11 4148d23
update license check
kellyguo11 cb96e3b
fix stage in memory
kellyguo11 ff67699
Change default Dockerfile path in action.yml
kellyguo11 012a1b4
stick to cu128 for x86
kellyguo11 b566920
Merge branch 'update-torch' of github.com:kellyguo11/IsaacLab-public …
kellyguo11 8afaa84
fix changelog version
kellyguo11 913758d
enable backwards compatibility with 5.1
kellyguo11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -1134,7 +1134,14 @@ def is_current_stage_in_memory() -> bool: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| def use_stage(stage: Usd.Stage) -> Generator[None, None, None]: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| """Context manager that sets a thread-local stage, if supported. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| In Isaac Sim < 5.0, this is a no-op to maintain compatibility. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| For Isaac Sim >= 6.0, this function sets the thread-local stage context in both the regular | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| and experimental stage utils modules. This is necessary because Isaac Sim has two separate | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| stage utility modules with independent thread-local storage: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - ``isaacsim.core.utils.stage`` (used by PhysicsContext) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| - ``isaacsim.core.experimental.utils.stage`` (used by SimulationManager) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| When using an in-memory stage, both contexts must be set to ensure that physics scene | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| validation and other operations work correctly. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Args: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| stage: The stage to set temporarily. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
@@ -1143,12 +1150,18 @@ def use_stage(stage: Usd.Stage) -> Generator[None, None, None]: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| None | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| """ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| isaac_sim_version = float(".".join(get_version()[2])) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if isaac_sim_version < 5: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| logger.warning("[Compat] Isaac Sim < 5.0 does not support thread-local stage contexts. Skipping use_stage().") | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| yield # no-op | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| else: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if isaac_sim_version < 6: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Set context in both modules to ensure all Isaac Sim subsystems see the correct stage | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| with stage_utils.use_stage(stage): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| yield | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| else: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Import both stage utils modules for Isaac Sim 5.0+ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| import isaacsim.core.experimental.utils.stage as experimental_stage_utils | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| # Set context in both modules to ensure all Isaac Sim subsystems see the correct stage | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| with stage_utils.use_stage(stage): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| with experimental_stage_utils.use_stage(stage): | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| yield | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
1152
to
+1164
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: inverted version comparison logic - code for Isaac Sim 6.0+ runs when version < 6, and code for Isaac Sim < 6.0 runs when version >= 6
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| def create_new_stage_in_memory() -> Usd.Stage: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this linter change?