Adds visual-based tactile sensor with shape sensing example#3420
Adds visual-based tactile sensor with shape sensing example#3420Mayankm96 merged 65 commits intoisaac-sim:mainfrom
Conversation
clean up license and configs; use full import path; add doc for visuo_tactile_sensor
|
|
||
| References | ||
| ~~~~~~~~~~ | ||
|
|
There was a problem hiding this comment.
@iakinola23 Could you help view this documentation here? Thanks!
There was a problem hiding this comment.
Hi @iakinola23 updated the documentation with your edits.
There was a problem hiding this comment.
@kellyguo11 Hi Kelly, I will upload the npz binaries, and the USD files to nucleus once the licensing concerns are resolved. Thanks!
kellyguo11
left a comment
There was a problem hiding this comment.
just a few high-level comments, haven't gone through the code in detail yet
| taxim_gelsight = gelsightRender("gelsight_r15") | ||
| import ipdb | ||
|
|
||
| ipdb.set_trace() |
There was a problem hiding this comment.
why is there a breakpoint here?
There was a problem hiding this comment.
deleted in the newest commit.
| self._camera_sensor = TiledCamera(self.cfg.camera_cfg) | ||
|
|
||
| # Initialize camera if not already done | ||
| # TODO: Juana: this is a hack to initialize the camera sensor. Should camera_sensor be managed by TacSL sensor or InteractiveScene? |
There was a problem hiding this comment.
maybe we can do something similar as the Raycaster camera?
There was a problem hiding this comment.
Hi Kelly, I checked the RayCasterCamera implementation, and it differs slightly from the tacsl sensor logic. The tacsl_sensor includes a camera sensor that can be enabled or disabled via the cfg, while RayCasterCamera only uses CameraData without having a camera or other sensor as a member. I’ve kept the current implementation and cleaned up the comments. Please let me know if you have any further concerns or suggestions.
There was a problem hiding this comment.
all changed to jpg format and documentation is updated accordingly.
| .. code-block:: bash | ||
|
|
||
| conda activate env_isaaclab | ||
| pip install opencv-python==4.11.0 trimesh==4.5.1 imageio==2.37.0 |
There was a problem hiding this comment.
do we need to add these to setup.py?
There was a problem hiding this comment.
Added opencv-python to setup.py; trimesh is already included, and imageio's dependency is not required in the newest commit.
| license agreement from NVIDIA CORPORATION is strictly prohibited. | ||
|
|
||
| ---------------- | ||
| Tensorized implementation of RGB rendering of gelsight-style visuo-tactile sensors |
There was a problem hiding this comment.
can you also add any licenses required for gelsight under docs/licenses?
There was a problem hiding this comment.
Updated the license header to be consistent with other files.
|
please also make sure to run ./isaaclab.sh -f for the linter checks |
| return dzdx, dzdy | ||
|
|
||
|
|
||
| def generate_normals(height_map): |
There was a problem hiding this comment.
generate_normals not needed and deprecated. only the tensorized version is used.
| self.background_tensor = torch.tensor(self.background, device=self.device) | ||
| print("Gelsight initialization done!") | ||
|
|
||
| def render(self, heightMap): |
There was a problem hiding this comment.
Delete render as it is not used. Only the tensorized version (render_tensorized ) is used.
There was a problem hiding this comment.
deleted render , generate_normals, and compute_image_gradient , padding as well.
|
Thank you for making TacSL available on IsaacLab! I have three quick questions:
Thanks! |
|
@ooctipus @Mayankm96 could you please help do a review of this one? |
|
@zxhuang97 Hi, thanks for your questions and for checking out TacSL on IsaacLab.
Hope this helps! |
source/isaaclab/isaaclab/sensors/tacsl_sensor/gelsight_render.py
Outdated
Show resolved
Hide resolved
…der.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Juana <yvetted@nvidia.com>
…der.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Juana <yvetted@nvidia.com>
…sor.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Juana <yvetted@nvidia.com>
…sor.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Juana <yvetted@nvidia.com>
…sor_cfg.py Co-authored-by: James Tigue <166445701+jtigue-bdai@users.noreply.github.com> Signed-off-by: Juana <yvetted@nvidia.com>
…g.py Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Signed-off-by: Juana <yvetted@nvidia.com>
|
Thank you very much for your contribution! @JuanaDd |
Signed-off-by: iakinola23 <147214266+iakinola23@users.noreply.github.com>
Signed-off-by: Juana <yvetted@nvidia.com>
@YuHoChau Hi, thanks for asking. This implementation uses the PhysX tensor API |
Thank you for your reply! |
Mayankm96
left a comment
There was a problem hiding this comment.
Merging this for now. I haven't tested it for functionality but the overall MR looks good. Thank you for the contribution.
…m#3420) # Description This is an implementation of TacSL integrated with Isaac Lab, which demonstrates how to properly configure and use tactile sensors to obtain realistic sensor outputs including tactile RGB images, force fields, and other relevant tactile measurements. ## Type of change - New feature (non-breaking change which adds functionality) ## Screenshots The screenshots of added documentation and simulation outputs. <img width="1121" height="878" alt="image" src="https://github.com/user-attachments/assets/5772a87b-474c-4a6c-87f5-b65aab102259" /> <img width="1311" height="669" alt="image" src="https://github.com/user-attachments/assets/8c2d4e66-2c12-4724-b6fd-8180f2fe9960" /> <img width="765" height="281" alt="image" src="https://github.com/user-attachments/assets/ad0e0899-7e3c-429f-9848-700d9310ae1b" /> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Juana <yvetted@nvidia.com> Co-authored-by: iakinola23 <147214266+iakinola23@users.noreply.github.com>
…m#3420) # Description This is an implementation of TacSL integrated with Isaac Lab, which demonstrates how to properly configure and use tactile sensors to obtain realistic sensor outputs including tactile RGB images, force fields, and other relevant tactile measurements. ## Type of change - New feature (non-breaking change which adds functionality) ## Screenshots The screenshots of added documentation and simulation outputs. <img width="1121" height="878" alt="image" src="https://github.com/user-attachments/assets/5772a87b-474c-4a6c-87f5-b65aab102259" /> <img width="1311" height="669" alt="image" src="https://github.com/user-attachments/assets/8c2d4e66-2c12-4724-b6fd-8180f2fe9960" /> <img width="765" height="281" alt="image" src="https://github.com/user-attachments/assets/ad0e0899-7e3c-429f-9848-700d9310ae1b" /> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Juana <yvetted@nvidia.com> Co-authored-by: iakinola23 <147214266+iakinola23@users.noreply.github.com>
Description
This is an implementation of TacSL integrated with Isaac Lab, which demonstrates how to properly configure and use tactile sensors to obtain realistic sensor outputs including tactile RGB images, force fields, and other relevant tactile measurements.
Fixes # (issue)
Type of change
Screenshots
The screenshots of added documentation and simulation outputs.



Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there